estewart@dudley.lib.usf.edu wrote:> > On an Ultra 1 running Solaris 2.6 and using gcc 2.8.1 > > ipc.c: In function `api_RNetServerEnum': > ipc.c:1194: warning: passing arg 4 of `qsort' from incompatible pointer > type > > Compiling nmbd_incomingrequests.c > nmbd_incomingrequests.c: In function `process_node_status_request': > nmbd_incomingrequests.c:380: warning: passing arg 4 of `qsort' from > incompatible pointer type > > Compiling client.c > client.c: In function `browse_host': > client.c:2972: warning: passing arg 4 of `qsort' from incompatible pointer > type > > The compile keeps running and otherwise runs fine; this is the > first time that I've had any kind of warnings using gcc (18p4 compiled > fine with gcc 2.8.1). > Should I worry about this? I'd think that GCC would always be the > compiler of choice these days...Unfortunately we tested with the Sun compiler, c'est la vie :-). We missed one QSORT_CAST define in includes.h for Solaris. It is just a warning and can be ignored. If it really bugs you add : #ifndef QSORT_CAST #define QSORT_CAST (int (*)(const void *, const void *)) #endif /* QSORT_CAST */ to the SUNOS5 section of includes.h (which is what is in the main branch). This is fixed in the main branch but got missed for 1.9.18p7, sorry (we were rather busy on other issues :-). Regards, Jeremy Allison. Samba Team. -- -------------------------------------------------------- Buying an operating system without source is like buying a self-assembly Space Shuttle with no instructions. --------------------------------------------------------
--On Thursday, May 14, 1998, 3:50 AM +1000 "Jeremy Allison" <jallison@whistle.com> wrote: } We missed one QSORT_CAST define in includes.h for Solaris. It } is just a warning and can be ignored. } } If it really bugs you add : } } #ifndef QSORT_CAST } #define QSORT_CAST (int (*)(const void *, const void *)) } #endif /* QSORT_CAST */ } } to the SUNOS5 section of includes.h (which is what is in } the main branch). BSDI 3.0 also complains about this one. Same fix, except in the BSDI section of includes.h. There are a couple of other warnings: nmbd_packets.c: In function `initiate_multihomed_name_register_packet': nmbd_packets.c:340: warning: passing arg 2 of `safe_strcpy' makes pointer from integer without a cast nmbd_subnetdb.c: In function `create_subnets': nmbd_subnetdb.c:190: warning: passing arg 1 of `make_subnet' makes pointer from integer without a cast I didn't chase those down, but it sounds like they're obvious from the warnings. Jim -- Jim Watt jimw@PE-Nelson.COM Perkin-Elmer Corporation Voice (desk): +1 408 577 2228 PE-Nelson Division Fax: +1 408 894 9307 3833 North First Street Voice (main): +1 408 577 2200 San Jose CA 95134-1701