rsync - Jan 2014 - [Bug 10381] New: --acls and --xattrs clash with --delete-missing-args

https://bugzilla.samba.org/show_bug.cgi?id=10381

           Summary: --acls and --xattrs clash with --delete-missing-args
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: blgl at stacken.kth.se
         QAContact: rsync-qa at samba.org


When missing files are to be passed through to the receiver, the sender
tries to get the ACL and xattrs even for a missing file.  This obviously
fails, the file is skipped, and the deletion doesn't happen.

The attached patch fixes the problem minimally and protocol-compatibly
by lower-level tweaking; ideally, the knowledge that st_mode == 0
means a missing file ought to be restricted to flist.c

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10381

--- Comment #1 from Bo Lindbergh <blgl at stacken.kth.se> 2014-01-15
11:10:04 UTC ---
Created attachment 9595
  --> https://bugzilla.samba.org/attachment.cgi?id=9595
Don't try to get ACLs or xattrs for missing files when --delete-missing-args
is
in effect.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10381

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Wayne Davison <wayned at samba.org> 2014-01-19
20:25:38 UTC ---
Nice catch.  I've made the same fix as yours, just using a new
IS_MISSING_FILE(statbuf) define to at least make the st_mode == 0 check a
little clearer.  Thanks for both the bug-report and the patch!

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.