rsync - Sep 2008 - DO NOT REPLY [Bug 5802] New: misleading error message in atomic rsync

https://bugzilla.samba.org/show_bug.cgi?id=5802

           Summary: misleading error message in atomic rsync
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: trivial
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: normalperson@yhbt.net
         QAContact: rsync-qa@samba.org


When renaming $dest_dir to $old_dir, don't say we're renaming
$new_dir to $old_dir on errors.

--- a/atomic-rsync
+++ b/atomic-rsync
@@ -48,7 +48,7 @@ if (system($RSYNC_PROG, "--link-dest=$dest_dir",
@ARGV)) {
     exit $?;
 }

-rename($dest_dir, $old_dir) or die "Unable to rename $new_dir to $old_dir:
$!";
+rename($dest_dir, $old_dir) or die "Unable to rename $dest_dir to
$old_dir:
$!"
 rename($new_dir, $dest_dir) or die "Unable to rename $new_dir to
$dest_dir:
$!"

 exit;


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5802


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from wayned@samba.org  2008-10-02 13:54 CST -------
I fixed this in the git repository.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5802


matt@mattmccutchen.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Comment #2 from matt@mattmccutchen.net  2008-10-02 19:49 CST -------
I do not see the fix in the git repository at
http://gitweb.samba.org/?p=rsync.git;a=summary .


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5802


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #3 from wayned@samba.org  2008-10-03 00:33 CST -------