rsync - Feb 2010 - DO NOT REPLY [Bug 7109] New: Need to define NO_SYMLINK_XATTR on Linux

https://bugzilla.samba.org/show_bug.cgi?id=7109

           Summary: Need to define NO_SYMLINK_XATTR on Linux
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: matt at mattmccutchen.net
         QAContact: rsync-qa at samba.org


NO_SYMLINK_XATTRS needs to be defined on Linux.  See:

http://git.savannah.gnu.org/cgit/attr.git/tree/man/man5/attr.5?id=1cc88bd4c17ef99ace22c8be362d513f155b1387#n116

It would be nice to have a portable configure test rather than hard-coding the
value for each OS.  Unfortunately, the test may need to use the abstraction
layer in lib/sysxattrs.c, which would not be available at configure time
without special tricks.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7109


matt at mattmccutchen.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Need to define              |Need to define
                   |NO_SYMLINK_XATTR on Linux   |NO_SYMLINK_XATTRS on Linux




------- Comment #1 from matt at mattmccutchen.net  2010-02-07 19:01 CST -------
Fixing typo in summary.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7109


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned at samba.org  2010-12-19 11:05 CST -------
Yeah, it would be nice to figure this out instead of hard-wiring it, but
we'll
just hard-wire it for now.

Eventually rsync may need to behave differently depending on the filesystem,
but we won't worry about that yet.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7109

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |WONTFIX

--- Comment #3 from Wayne Davison <wayned at samba.org> 2011-06-04
23:57:49 UTC ---
Since the read function doesn't generate an error, it shouod be fine to just
let any attempt to set user xattrs on a symlink generate an error.  Is there
anything I'm missing?

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=7109

Matt McCutchen <matt at mattmccutchen.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |

--- Comment #4 from Matt McCutchen <matt at mattmccutchen.net> 2011-06-05
00:48:12 UTC ---
(In reply to comment #3)
> Since the read function doesn't generate an error, it shouod be fine to
just
> let any attempt to set user xattrs on a symlink generate an error.  Is
there
> anything I'm missing?
Yes: bug 7110.  NO_SYMLINK_XATTRS is needed to trigger the code path that
converts the symlink to a regular file to be able to set the fake-super xattr. 
Without it, rsync will try to set the xattr on the symlink, generating an EPERM
which is swallowed by a test you apparently wrote to allow fake-super to work
on a best-effort basis before the introduction of the NO_SYMLINK_XATTRS switch.

So, you can either detect the EPERM and convert the symlink to a regular file
then, or have a separate NO_SYMLINK_USER_XATTRS switch.  But either way, the
EPERM test should go now that it is masking a failure that rsync is supposed to
be able to avoid.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=7109

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Wayne Davison <wayned at samba.org> 2011-06-18
18:28:22 UTC ---
Will be fixed in 3.1.0.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=7109

Matt McCutchen <matt at mattmccutchen.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #6 from Matt McCutchen <matt at mattmccutchen.net> 2011-06-18
18:55:21 UTC ---
do_readlink needs to use the same condition as do_symlink.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=7109

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Wayne Davison <wayned at samba.org> 2011-06-18
20:44:01 UTC ---
Thanks -- I missed the other 2 #if changes.  Fixed now.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.