rsync - Jan 2008 - [PATCH] Fix backwards comment about logging on a local run.

---
Since the process executing the code inside the previous "if" (which
doesn't close the log file) sets am_server = 1, I think the comment is
backwards.

 pipe.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pipe.c b/pipe.c
index 12aa73d..101d4cb 100644
--- a/pipe.c
+++ b/pipe.c
@@ -150,7 +150,7 @@ pid_t local_child(int argc, char **argv, int *f_in, int
*f_out,
 		child_main(argc, argv);
 	}
 
-	/* Let the client side handle this. */
+	/* Let the server side handle this. */
 	if (logfile_name) {
 		logfile_name = NULL;
 		logfile_close();
-- 
1.5.4.rc3.15.g4bbc

On Tue, Jan 29, 2008 at 09:45:08PM -0500, Matt McCutchen
wrote:
> Since the process executing the code inside the previous "if"
(which
> doesn't close the log file) sets am_server = 1, I think the comment is
> backwards.
No, it's saying (or attempting to say) that the client will handle the
logging, so the server is closing the logfile.

..wayne..

On Tue, Jan 29, 2008 at 09:45:08PM -0500, Matt McCutchen
wrote:
> Since the process executing the code inside the previous "if"
(which
> doesn't close the log file) sets am_server = 1, I think the comment is
> backwards.
Yep, you're quite right.  Sorry for the confusion in the first reply.  I
really want the client side to do the logging in a local transfer, so I
moved the code to make that happen.

..wayne..