rsync - Jan 2008 - DO NOT REPLY [Bug 5220] New: PATCH SUBMITTED: New Feature: stdio model for client

https://bugzilla.samba.org/show_bug.cgi?id=5220

           Summary: PATCH SUBMITTED: New Feature: stdio model for client
           Product: rsync
           Version: 3.0.0
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: samba@davyandbeth.com
         QAContact: rsync-qa@samba.org


I've created a simple patch that allows the user to specify
'&<integer>' for
the hostname which causes it to use that specified file-descriptor as an
already connected socket so that a program can connect for rsync,
pre-communicate and then exec rsync (the normal stdio model).

The existing --rsh feature can perhaps just barely be used to do this if you
bend over backwards, but this simplifies it.  But this allows the connection to
be made  BEFORE even executing rsync rather than vice-versa.

I've also updated the man page.  I didn't know what else might need to
be
updated.  I'll be glad to enhance it further if necessary


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5220





------- Comment #1 from samba@davyandbeth.com  2008-01-21 22:35 CST -------
Created an attachment (id=3116)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3116&action=view)
This patch implements the described feature

This patch has be preliminarily tested.  I will update if any issues are found
while using in production.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5220





------- Comment #2 from matt@mattmccutchen.net  2008-01-23 00:55 CST -------
You can make rsync effectively use an existing fd by passing an
$RSYNC_CONNECT_PROG that refers to a program that shuttles data between its
stdin/stdout and the desired fd.  I'm not sure that it is worth adding the
&
syntax to the official rsync.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5220





------- Comment #3 from samba@davyandbeth.com  2008-01-23 10:59 CST -------
(In reply to comment #2)
> You can make rsync effectively use an existing fd by passing an
> $RSYNC_CONNECT_PROG that refers to a program that shuttles data between its
> stdin/stdout and the desired fd.  I'm not sure that it is worth adding
the &
> syntax to the official rsync.
> 
I'm aware of that, but you have to have yet another process and have some
application to do that for you rather than follow the usual stdio pattern (set
up fd, fork/exec).  This patch makes things more resource efficient.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5220


matt@mattmccutchen.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Client option to use a      |Syntax to access a daemon
                   |socket supplied on a fd     |over a socket supplied on a
                   |                            |fd




------- Comment #4 from matt@mattmccutchen.net  2008-06-02 15:56 CST -------
I'm sorry for the noise as I try to get the summary right.

I've changed my mind about this enhancement: I'm now in favor of it
because the
implementation is so simple and it would provide a slightly easier and
better-performing way to embed rsync in other programs that already have a
network connection, such as my continusync (if I ever finish it).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5220





------- Comment #5 from samba@davyandbeth.com  2008-06-03 22:19 CST -------
(In reply to comment #4)
> it would provide a slightly easier and
> better-performing way to embed rsync in other programs that already have a
> network connection, such as my continusync (if I ever finish it).
> 
That's exactly the situation I had too. I had an existing network connection
and wanted to let rsync have the rest of the traffic.  So I exec() rsync when
I'm done talking to the other side (and he exec's it too).

Thanx


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5220





------- Comment #6 from matt@mattmccutchen.net  2009-01-12 23:18 CST -------
I noticed that this was proposed a long time ago:

http://lists.samba.org/archive/rsync/2003-March/005418.html

It looks like JW Schultz was proposing treating a client with a supplied
connection as a special kind of server with am_server set to a distinctive
value.  I don't think that approach will work now that the client/server
distinction means many things besides whether to make a connection or use a
provided one, so the current approach of just hooking the code that makes the
connection is correct.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.