rsync - Nov 2009 - DO NOT REPLY [Bug 6915] New: Reject passing an argument to an option that doesn't take one

https://bugzilla.samba.org/show_bug.cgi?id=6915

           Summary: Reject passing an argument to an option that doesn't
                    take one
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: matt at mattmccutchen.net
         QAContact: rsync-qa at samba.org


Rsync should reject an attempt to pass an argument to a command-line option
that doesn't take an argument.  For example, this incorrect attempt to
disable
--perms should be rejected:

$ rsync -a --perms=off ...

Currently it works just like --perms.

The above example was seen on the rsnapshot list:

http://sourceforge.net/mailarchive/message.php?msg_name=op.u3o0ozeqijpzuf%40arch.che.intra.net


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6915





------- Comment #1 from wayned at samba.org  2009-11-20 18:09 CST -------
I'd imagine that this is a bug for the popt library.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6915





------- Comment #2 from matt at mattmccutchen.net  2009-11-20 20:43 CST -------
Reported upstream:

http://rpm5.org/cvs/tktview?tn=54

But don't bother trying to comment there: their bug tracker doesn't
allow
non-developers to comment.  That's ridiculous.  I complained about that too:

http://rpm5.org/cvs/tktview?tn=55


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6915





------- Comment #3 from matt at mattmccutchen.net  2009-11-20 20:47 CST -------
Created an attachment (id=4974)
 --> (https://bugzilla.samba.org/attachment.cgi?id=4974&action=view)
Patch for rsync's included popt

For now, here's a patch applicable to rsync's included popt.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6915


matt at mattmccutchen.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #4974 is|0                           |1
           obsolete|                            |




------- Comment #4 from matt at mattmccutchen.net  2009-11-20 21:57 CST -------
Created an attachment (id=4975)
 --> (https://bugzilla.samba.org/attachment.cgi?id=4975&action=view)
Better patch (catch --quiet)


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6915


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #5 from wayned at samba.org  2010-08-21 16:51 CST -------
This is now fixed in rsync and upstream.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.