rsync - Feb 2007 - DO NOT REPLY [Bug 4402] New: Incorrect time logged with glibc 2.5

https://bugzilla.samba.org/show_bug.cgi?id=4402

           Summary: Incorrect time logged with glibc 2.5
           Product: rsync
           Version: 2.6.9
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: kilburna@iservnetworks.com
         QAContact: rsync-qa@samba.org


rsync 2.6.9 fixed the time logging. I upgraded to glibc 2.5. The time loggin
problem again started.  Problem still persists after a recompile.

Using Gentoo 2.6.19 + glibc 2.5.
>From logs (with glibc 2.3 and rsync 2.6.9)
Time: Mon Feb 12 15:46:43 EST 2007
2007/02/12 04:46:43 [16263] receiving file list
2007/02/12 04:46:43 [16263] sent 85 bytes  received 393 bytes  total size
244652

It should be (with glibc 2.5 and rsync 2.6.9)
2007/02/12 15:46:43 [16263] receiving file list
2007/02/12 15:46:43 [16263] sent 85 bytes  received 393 bytes  total size
244652

I also compiled the latest CVS version, and it also shows the incorrect logged
time.

I have to set chroot = no, for the time to display correctly.

Also confirmed on Fedora system with glibc 2.5


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Incorrect time logged with  |Incorrect time logged with
                   |glibc 2.5                   |glibc 2.5 inside chroot area




------- Comment #1 from wayned@samba.org  2007-02-18 08:18 MST -------
Isn't this a glibc bug that needs to be fixed by them, not rysnc?

Did you try setting the TZ environment variable in the environment of your
rsync daemon to see if that helps the latest strftime() output correctly?


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




------- Comment #3 from wayned@samba.org  2007-07-14 14:50 CST -------
I don't think there's anything more that rsync can do about this issue
when
chroot is in effect.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402


smb23@realcomputerguy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |smb23@realcomputerguy.com




------- Comment #4 from smb23@realcomputerguy.com  2007-07-18 12:40 CST -------
Is there anything to be done about this?
Problem still exists today with 2.6.9 and both glibc-2.5 and glibc-2.6.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402





------- Comment #5 from hashproduct+rsync@gmail.com  2007-07-18 13:41 CST
-------
Created an attachment (id=2829)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2829&action=view)
Chroot + timezone test program

I wrote a small test program in C to try to reproduce the problem without rsync
(attached).  Strangely enough, none of the several variations of the program
that I tried exhibit the problem, while an rsync daemon I set up does.  I
wonder what rsync is doing differently.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402





------- Comment #6 from hashproduct+rsync@gmail.com  2007-07-18 13:44 CST
-------
I should add that I tested on Fedora 7 with glibc-2.6-4 .


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402





------- Comment #7 from wayned@samba.org  2007-07-18 17:24 CST -------
(In reply to comment #5)
> Strangely enough, none of the several variations of the program
> that I tried exhibit the problem, while an rsync daemon I set up does.
Did you try using localtime() instead of localtime_r()?  I wonder if the latter
would help rsync?

Did you try forking after the chroot?


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402





------- Comment #8 from hashproduct+rsync@gmail.com  2007-07-21 09:13 CST
-------
Created an attachment (id=2836)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2836&action=view)
Test program #2

(In reply to comment #7)
> Did you try using localtime() instead of localtime_r()?  I wonder if the
latter
> would help rsync?
> 
> Did you try forking after the chroot?
I changed the program to use localtime() and forked both before and after the
chroot (attached).  Nevertheless, all four processes gave the correct time. 
This is really puzzling.  I suppose I will have to butcher a copy of the rsync
source code down to a test program little by little and see when the inaccuracy
goes away.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4402





------- Comment #9 from matt@mattmccutchen.net  2008-04-03 12:27 CST -------
Note that the chroot+path mode added in rsync 3.0.0 can be used to work around
this problem by having the daemon chroot into a directory containing a correct
/etc/localtime file and putting the module somewhere inside that directory.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.