rsync - Feb 2006 - DO NOT REPLY [Bug 3554] New: Second copy of same rsync daemon should notice pid file and quit

https://bugzilla.samba.org/show_bug.cgi?id=3554

           Summary: Second copy of same rsync daemon should notice pid file
                    and quit
           Product: rsync
           Version: 2.6.7
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: hashproduct@verizon.net
         QAContact: rsync-qa@samba.org


If two rsync daemons using the same pid file are started, the second one should
notice the pid file and quit.  Right now, the second daemon overwrites the pid
file, fails to listen on the port, and then removes the pid file, leaving the
first daemon running without a pid file (harder to kill automatically).  The
fix is as simple as adding O_EXCL to the do_open(lp_pid_file(), ...) call in
clientserver.c.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3554





------- Comment #1 from rsync@blubb.ch  2006-10-11 17:34 MST -------
Created an attachment (id=2181)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2181&action=view)
patch 

I can reproduce this issue. The described change fixes it:

# /etc/init.d/rsyncd start
# cat /var/run/rsyncd.pid
9913
# pgrep rsync
9913
# /etc/init.d/rsyncd zap (trick the rc system to think the service is stopped)
# /etc/init.d/rsyncd start
# cat /var/run/rsyncd.pid
9913
# pgrep rsync
9913


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3554


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned@samba.org  2007-09-30 21:30 CST -------
This is now fixed in CVS.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3554


tm@vl.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tm@vl.com




------- Comment #3 from tm@vl.com  2007-10-22 12:02 CST -------
I think this patch is flawed as it seems to lack a mechanism to check for stale
PIDs.

On a Windows system running rsync 3.0.0pre1, rebooting after a crash results
in:

2007/10/19 11:55:45 [127] rsync: failed to create pid file
/cygdrive/c/var/pgm/log/rsyncd.pid: File exists (17)

2007/10/19 11:55:45 [127] rsync error: error in file IO (code 11) at
clientserver.c(857) [receiver=3.0.0pre1]

The PID in rsyncd.pid is no longer pointing to a process.

Should I open a new bug?


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3554





------- Comment #4 from wayned@samba.org  2007-10-22 16:33 CST -------
I left out the breaking of a stale lock file on purpose, as I could imagine
that some folks wouldn't want auto-breaking.  Those that do can easily add
in
either (1) file-removal at boot or (2) stale lock file checking in the daemon
startup script.  However, maybe it should be an option -- if you want to
suggest that, feel free to open an enhancement bug.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.