rsync - Dec 2005 - [Bug 3298] New: --rsh option incorrectly interprets quotes

https://bugzilla.samba.org/show_bug.cgi?id=3298

           Summary: --rsh option incorrectly interprets quotes
           Product: rsync
           Version: 2.6.6
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: devin@freeshell.org
         QAContact: rsync-qa@samba.org


Using rsync -e 'ssh -i "/some directory with spaces/identity"'
causes rsync to
try to execute ssh like:

execve("/usr/bin/ssh", ["ssh", "-i",
"\"/some directory with
spaces/identity\"", ...])

Which of course fails, because the quotes were to delimit the argument, not
part of the filename.  This makes it more difficult to use options with spaces
and is inconsistant with the --rsync-path option, which uses sh to interpret
the command.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3298


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from wayned@samba.org  2005-12-14 15:04 MST -------
I added single- and double-quote parsing to rsync''s handling of the
remote-shell command.  Rsync doesn''t use the shell to parse this string
(since
that could cause problems for the option-forwarding code).  I decided to not
include backslash parsing in order to (1) keep it simple and (2) avoid causing
problems for cygwin users.  I also decided to keep the quirk that tabs are not
considered arg-breaking characters.  This should give us very good
backward-compatibility.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.