rsync - Oct 2005 - [Bug 3198] rsyncing a file to a dest path where dirname(path) is a file quietly fails

https://bugzilla.samba.org/show_bug.cgi?id=3198


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2005-10-20 09:45 -------
This has already been fixed in the CVS version, so it will appear in the next
release.

In currently released versions of rsync, the error is hidden unless -vv is
specified, which is clearly wrong (as you discovered).  It is easy to patch this
fix into any version of rsync by looking for the stat() error in generator.c and
removing the "if (verbose > 1)" check.  The code will then look
like this:

        rsyserr(FERROR, stat_errno, "recv_generator: failed to stat
%s",
                full_fname(fname));

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3198





------- Additional Comments From hashproduct@verizon.net  2005-10-20 13:37
-------
A side note in case anyone is interested:

My custom rsync, in order to observe default ACLs correctly, needed a change to
the behavior of "get_local_name".  Even if only a single source file
is being
transferred to a single destination file, the receiving rsync changes into the
directory of the destination file.  (In fact, I found the idea of "local
names"
so confusing that I rewrote "get_local_name", adding additional
comments and
verbose output.)

A side effect of the change is that, on my rsync, "rsync -v foo
bar/cuz" will
fail during file selection as it should.  It says:
    rsync: push_dir#2.5 "/path/to/bar/cuz" failed: No such file or
directory (2)
    rsync error: errors selecting input/output files, dirs (code 3) at
main.c(498)
    rsync: connection unexpectedly closed (8 bytes received so far) [sender]
    rsync error: error in rsync protocol data stream (code 12) at io.c(434)
(I just realized that while the attempted push_dir is correct, the path in the
error message is wrong: it should be "/path/to/bar".  I'll fix
this.)

My rsync is available here:
    http://mysite.verizon.net/hashproduct/myrsync/

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.