rsync - Sep 2004 - [Bug 1764] dry-run does not show changes in owner / group, permission, or timestamp

https://bugzilla.samba.org/show_bug.cgi?id=1764


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|NEW                         |ASSIGNED
           Priority|P3                          |P4




------- Additional Comments From wayned@samba.org  2004-09-16 15:43 -------
Yes, rsync doesn't output filenames that aren't being transferred, so
when it
just twiddles the attributes of a file (such as the mode or group), it usually
does that silently (unless debugging levels of verbosity are used).

I'll consider this as an enhancement request for the future.  Certainly we
want
to make better logging possible, but we do need to be careful about chaing the
output of the standard verbose mode (which some folks parse in their scripts).

Note also that you should attach patches to a bug report rather than pasting it
into the comments.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1764





------- Additional Comments From mwang@unixlabplus.com  2004-09-16 21:09 -------
Created an attachment (id=666)
 --> (https://bugzilla.samba.org/attachment.cgi?id=666&action=view)
patch for rsync.c

The patch addresses 2 issues.

(1) under dry-run mode, files with attribute changes are not listed even with
two -v flags.

I consider this as a bug because (a) dry-run mode "will just report the
actions
it would have taken". Taking off the dry-run mode the files are reported
with
two -v flags. (b) under dry run mode, the information for files with attribute
changes is not available which violates the Freedom of Information Act.

(2) List the files with attribute changes with one -v flag. While this is
arguable, my side of arguments are (a) attributes are part of a file, it may be
as important as, or more important than, the content depending what you do; (b)
Man page says "Two -v flags will give you information on what files  are 
being
skipped and slightly more information at the end". The current behavior
that
two -v flags list attribute changes does not agree with documentation.

(Wayne's reply addressed issue #2, but not #1).

The following is additional enhancement request not addressed by the patch:

The better approach, putting aside of the backward compatibility, is to report
all the changes, and flag each type of changes with new, delete, content
update, permission, owner, group, modification time, what else. This way,
people can parse and select what they need.

Thank you.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1764


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P4                          |P5




------- Additional Comments From wayned@samba.org  2004-09-17 16:43 -------
Yes, there is an inconsistency in --dry-run mode with -vv verbosity, but it will
be harder to fix than what you proposed.  For instance, your fix doesn't
handle
the case where the directory needs to be created (it would replace the
now-silent directory-creation behavior in --dry-run mode with a stat error), it
outputs only the first change it finds (there could multiple multiple things
that need to be updated), and it introduces a new output syntax into verbose
mode that we need to consider carefully (as it affects the scripting of rsync).
 A better long-term solution is to introduce a configurable logging system that
lets the user ask for the type of change information they want to see.

These dry-run bugs are not a high priority to fix right now, but will be looked
into later on.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.