rsync - Aug 2004 - [Bug 1660] --exclude option causes rsync to fail

https://bugzilla.samba.org/show_bug.cgi?id=1660


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From wayned@samba.org  2004-08-25 08:32 -------
This is because you're manually specifying the --server option.  The
--exclude
option is specified to the client rsync, and it sends the excludes to the server
via the socket (when necessary), so the exclude option is not supposed to be
used when running the server. Are you trying to do something tricky here?

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1660





------- Additional Comments From cbarratt@users.sourceforge.net  2004-08-25
14:03 -------
Wayne,

This is the way BackupPC (using File::RsyncP) invokes the client side
of rsync.  This is perl code that emulates one side of the rsync
connection, and the real rsync is used as the server side with the
--server option.

I agree that using the --server option manually in this manner is subject
to change, so I can't reasonably expect backward compatibility for an
internal feature.

So it looks like I should update File::RsyncP to send the exclude arguments
through the socket instead of arglist.  Up until 2.6.2 the arglist method
worked fine.

Craig


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1660


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2004-08-26 10:43 -------
(In reply to comment #2)
> This is the way BackupPC (using File::RsyncP) invokes the client side
> of rsync.
OK.  My earlier choice to get rid of the server-side support for these options
was because the --include-from/--exclude-from options needed  little more
security and I didn't know that some non-standard setup was using them. 
I've
changed the code to allow them again, and added the extra security check needed.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1660





------- Additional Comments From cbarratt@users.sourceforge.net  2004-08-26
20:34 -------
Wayne,

That's really great.  It's definitely above and beyond the call of
duty to provide backward compatibility for undocumented/unsupported
features.

I really appreciate your efforts.

I will still go ahead and provide correct support for excludes via
the socket interface, but decoupling this from the 2.6.3 release is
a huge help.

Craig


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.