Hi all, Not sure if I''m the only one with this problem... We''re on edge for both rails and rspec, and i just did an update... Some apparently innocuous rails stuff was updated, and then half my specs broke due to an error in rspec_on_rails: ArgumentError in ''UserController without logged in user should show the index page'' wrong number of arguments (2 for 1) ..../vendor/plugins/rspec_on_rails/lib/spec/rails/example/behaviour/ controller_example_group.rb:188:in `render'' I tried backtracking to an earlier version of rails with no luck. Can anyone provide some version numbers (for rspec, rspec on rails, and rails itself) that I can downgrade back to so my specs work again? Thanks a lot! Daniel
On Nov 28, 2007 8:29 AM, Daniel Tenner <daniel.ruby at tenner.org> wrote:> Hi all, > > Not sure if I''m the only one with this problem... > > We''re on edge for both rails and rspec, and i just did an update... > Some apparently innocuous rails stuff was updated, and then half my > specs broke due to an error in rspec_on_rails: > ArgumentError in ''UserController without logged in user should show > the index page'' > wrong number of arguments (2 for 1) > ..../vendor/plugins/rspec_on_rails/lib/spec/rails/example/behaviour/ > controller_example_group.rb:188:in `render'' > > I tried backtracking to an earlier version of rails with no luck. > > Can anyone provide some version numbers (for rspec, rspec on rails, > and rails itself) that I can downgrade back to so my specs work again?I just updated to edge rails 8228 and it runs fine with rspec at rev 2997 (current trunk) What revisions are you using?> > Thanks a lot! > > Daniel > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >
To avoid this sort of issue, I recommend using piston. With piston you can check in revision combinations that actually work in your source tree without using svn externals. Stefan 2007/11/28, Daniel Tenner <daniel.ruby at tenner.org>:> > Hi all, > > Not sure if I''m the only one with this problem... > > We''re on edge for both rails and rspec, and i just did an update... > Some apparently innocuous rails stuff was updated, and then half my > specs broke due to an error in rspec_on_rails: > ArgumentError in ''UserController without logged in user should show > the index page'' > wrong number of arguments (2 for 1) > ..../vendor/plugins/rspec_on_rails/lib/spec/rails/example/behaviour/ > controller_example_group.rb:188:in `render'' > > I tried backtracking to an earlier version of rails with no luck. > > Can anyone provide some version numbers (for rspec, rspec on rails, > and rails itself) that I can downgrade back to so my specs work again? > > Thanks a lot! > > Daniel > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >-- Bekk Open Source http://boss.bekk.no -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20071128/9a4e9b2f/attachment-0001.html
8228 and 2997! :-( Dang.. what else could it be? It looks like basically, "render" is what''s broken... all the pages with redirect_to are working fine in the specs. When I take one of the broken actions and make it redirect_to instead of rendering, the number of failures goes down, and the line that''s breaking in controller_example_group.rb is: super(options, deprecated_status, &block) in the render method of the ControllerInstanceMethods module. No idea why it breaks though (or why it''s breaking only for me!)... Daniel On 28 Nov 2007, at 14:36 28 Nov 2007, David Chelimsky wrote:> On Nov 28, 2007 8:29 AM, Daniel Tenner <daniel.ruby at tenner.org> wrote: >> Hi all, >> >> Not sure if I''m the only one with this problem... >> >> We''re on edge for both rails and rspec, and i just did an update... >> Some apparently innocuous rails stuff was updated, and then half my >> specs broke due to an error in rspec_on_rails: >> ArgumentError in ''UserController without logged in user should show >> the index page'' >> wrong number of arguments (2 for 1) >> ..../vendor/plugins/rspec_on_rails/lib/spec/rails/example/behaviour/ >> controller_example_group.rb:188:in `render'' >> >> I tried backtracking to an earlier version of rails with no luck. >> >> Can anyone provide some version numbers (for rspec, rspec on rails, >> and rails itself) that I can downgrade back to so my specs work >> again? > > I just updated to edge rails 8228 and it runs fine with rspec at rev > 2997 (current trunk) > > What revisions are you using? > >> >> Thanks a lot! >> >> Daniel >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users
On Nov 28, 2007 8:44 AM, Daniel Tenner <daniel.ruby at tenner.org> wrote:> 8228 and 2997! :-( > > Dang.. what else could it be? It looks like basically, "render" is > what''s broken... all the pages with redirect_to are working fine in > the specs. When I take one of the broken actions and make it > redirect_to instead of rendering, the number of failures goes down, > and the line that''s breaking in controller_example_group.rb is: > super(options, deprecated_status, &block) > > in the render method of the ControllerInstanceMethods module. > > No idea why it breaks though (or why it''s breaking only for me!)...Did you do a clean install of edge rails, rspec and rspec_on_rails? If not, I''d recommend it. Perhaps it''s an update problem (as Stefan proposed) as opposed to a code problem.> > Daniel > > > On 28 Nov 2007, at 14:36 28 Nov 2007, David Chelimsky wrote: > > > On Nov 28, 2007 8:29 AM, Daniel Tenner <daniel.ruby at tenner.org> wrote: > >> Hi all, > >> > >> Not sure if I''m the only one with this problem... > >> > >> We''re on edge for both rails and rspec, and i just did an update... > >> Some apparently innocuous rails stuff was updated, and then half my > >> specs broke due to an error in rspec_on_rails: > >> ArgumentError in ''UserController without logged in user should show > >> the index page'' > >> wrong number of arguments (2 for 1) > >> ..../vendor/plugins/rspec_on_rails/lib/spec/rails/example/behaviour/ > >> controller_example_group.rb:188:in `render'' > >> > >> I tried backtracking to an earlier version of rails with no luck. > >> > >> Can anyone provide some version numbers (for rspec, rspec on rails, > >> and rails itself) that I can downgrade back to so my specs work > >> again? > > > > I just updated to edge rails 8228 and it runs fine with rspec at rev > > 2997 (current trunk) > > > > What revisions are you using? > > > >> > >> Thanks a lot! > >> > >> Daniel > >> _______________________________________________ > >> rspec-users mailing list > >> rspec-users at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-users > >> > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >
Ok, I''ve ditched externals and switched to piston... wiped out all the plugins and reinstalled them... And still I''m getting that error. No one else is getting this? Daniel On 28 Nov 2007, at 14:49 28 Nov 2007, David Chelimsky wrote:> On Nov 28, 2007 8:44 AM, Daniel Tenner <daniel.ruby at tenner.org> wrote: >> 8228 and 2997! :-( >> >> Dang.. what else could it be? It looks like basically, "render" is >> what''s broken... all the pages with redirect_to are working fine in >> the specs. When I take one of the broken actions and make it >> redirect_to instead of rendering, the number of failures goes down, >> and the line that''s breaking in controller_example_group.rb is: >> super(options, deprecated_status, &block) >> >> in the render method of the ControllerInstanceMethods module. >> >> No idea why it breaks though (or why it''s breaking only for me!)... > > Did you do a clean install of edge rails, rspec and rspec_on_rails? If > not, I''d recommend it. Perhaps it''s an update problem (as Stefan > proposed) as opposed to a code problem. > >> >> Daniel >> >> >> On 28 Nov 2007, at 14:36 28 Nov 2007, David Chelimsky wrote: >> >>> On Nov 28, 2007 8:29 AM, Daniel Tenner <daniel.ruby at tenner.org> >>> wrote: >>>> Hi all, >>>> >>>> Not sure if I''m the only one with this problem... >>>> >>>> We''re on edge for both rails and rspec, and i just did an update... >>>> Some apparently innocuous rails stuff was updated, and then half my >>>> specs broke due to an error in rspec_on_rails: >>>> ArgumentError in ''UserController without logged in user should show >>>> the index page'' >>>> wrong number of arguments (2 for 1) >>>> ..../vendor/plugins/rspec_on_rails/lib/spec/rails/example/ >>>> behaviour/ >>>> controller_example_group.rb:188:in `render'' >>>> >>>> I tried backtracking to an earlier version of rails with no luck. >>>> >>>> Can anyone provide some version numbers (for rspec, rspec on rails, >>>> and rails itself) that I can downgrade back to so my specs work >>>> again? >>> >>> I just updated to edge rails 8228 and it runs fine with rspec at rev >>> 2997 (current trunk) >>> >>> What revisions are you using? >>> >>>> >>>> Thanks a lot! >>>> >>>> Daniel >>>> _______________________________________________ >>>> rspec-users mailing list >>>> rspec-users at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/rspec-users >>>> >>> _______________________________________________ >>> rspec-users mailing list >>> rspec-users at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-users >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users
Found the culprit. It was RubyAMF. We''ve emailed them about it. In the meantime, for anyone else who might encounter this problem, changing line 188 of controller_example_group from: super(options, deprecated_status, &block) to: super(options, &block) Makes all the specs pass. Obviously not a desirable permanent change... but at least until RubyAMF gets fixed. Thanks for the help all! Daniel On 28 Nov 2007, at 16:39 28 Nov 2007, Daniel Tenner wrote:> Ok, I''ve ditched externals and switched to piston... wiped out all > the plugins and reinstalled them... > > And still I''m getting that error. > > No one else is getting this? > > Daniel > > On 28 Nov 2007, at 14:49 28 Nov 2007, David Chelimsky wrote: > >> On Nov 28, 2007 8:44 AM, Daniel Tenner <daniel.ruby at tenner.org> >> wrote: >>> 8228 and 2997! :-( >>> >>> Dang.. what else could it be? It looks like basically, "render" is >>> what''s broken... all the pages with redirect_to are working fine in >>> the specs. When I take one of the broken actions and make it >>> redirect_to instead of rendering, the number of failures goes down, >>> and the line that''s breaking in controller_example_group.rb is: >>> super(options, deprecated_status, &block) >>> >>> in the render method of the ControllerInstanceMethods module. >>> >>> No idea why it breaks though (or why it''s breaking only for me!)... >> >> Did you do a clean install of edge rails, rspec and >> rspec_on_rails? If >> not, I''d recommend it. Perhaps it''s an update problem (as Stefan >> proposed) as opposed to a code problem. >> >>> >>> Daniel >>> >>> >>> On 28 Nov 2007, at 14:36 28 Nov 2007, David Chelimsky wrote: >>> >>>> On Nov 28, 2007 8:29 AM, Daniel Tenner <daniel.ruby at tenner.org> >>>> wrote: >>>>> Hi all, >>>>> >>>>> Not sure if I''m the only one with this problem... >>>>> >>>>> We''re on edge for both rails and rspec, and i just did an >>>>> update... >>>>> Some apparently innocuous rails stuff was updated, and then >>>>> half my >>>>> specs broke due to an error in rspec_on_rails: >>>>> ArgumentError in ''UserController without logged in user should >>>>> show >>>>> the index page'' >>>>> wrong number of arguments (2 for 1) >>>>> ..../vendor/plugins/rspec_on_rails/lib/spec/rails/example/ >>>>> behaviour/ >>>>> controller_example_group.rb:188:in `render'' >>>>> >>>>> I tried backtracking to an earlier version of rails with no luck. >>>>> >>>>> Can anyone provide some version numbers (for rspec, rspec on >>>>> rails, >>>>> and rails itself) that I can downgrade back to so my specs work >>>>> again? >>>> >>>> I just updated to edge rails 8228 and it runs fine with rspec at >>>> rev >>>> 2997 (current trunk) >>>> >>>> What revisions are you using? >>>> >>>>> >>>>> Thanks a lot! >>>>> >>>>> Daniel >>>>> _______________________________________________ >>>>> rspec-users mailing list >>>>> rspec-users at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/rspec-users >>>>> >>>> _______________________________________________ >>>> rspec-users mailing list >>>> rspec-users at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/rspec-users >>> >>> _______________________________________________ >>> rspec-users mailing list >>> rspec-users at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-users >>> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users