Rails - Jan 2012 - Any help with refactory this ugly code?

https://gist.github.com/1644085

#verifications/index.haml
- if Ad.unverified_ads.size == 0
- else
  = link_to "Fast Verify",
fast_verify_info_verification_path(Ad.unverified_ads.last), :method =>
:put
= link_to "Normal Verify", verify_info_verification_path(ad), :method
=>
:put

#verifications/verify_info.haml
= link_to "Verify", verify_verification_path(@ad)

#verifications/fast_verify_info.haml
= link_to "Verify",
fast_verify_verification_path(Ad.unverified_ads.last), :method => :put

#verification_controller.rb
  def verify_info
    @ad = Ad.find(params[:id])
  end

  def fast_verify_info
    @ad = Ad.find(params[:id])
  end

  def fast_verify
    @ad = Ad.find(params[:id])
    @ad.verify!
    if Ad.unverified_ads.size == 0
      redirect_to verifications_path
    else
    redirect_to
fast_verify_info_verification_path(Ad.unverified_ads.last)
    end
  end

  def verify
    @ad = Ad.find(params[:id])
    @ad.verify!
    if params[:fast] == true
      redirect_to Ad.unverified_ads.last
    else
    redirect_to verifications_path
    end
  end

I think there is too many actions, how to improve this?

-- 
Posted via http://www.ruby-forum.com/.

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.

Try replacing the redundant bits one at a time. For instance:

  Ad.unverified_ads.size == 0
is equivalent to
  Ad.unverified_ads.blank?

And you''re repeating "if...else" a lot with just one line in
each, so
turn it into a ternary:

   if Ad.unverified_ads.size == 0
     redirect_to verifications_path
   else
     redirect_to fast_verify_info_verification_path(Ad.unverified_ads.last)
   end

becomes

   redirect_to (Ad.unverified_ads.blank? ? verifications_path :
fast_verify_info_verification_path(Ad.unverified_ads.last))

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.

Thanks a lot, this my amendments.
https://gist.github.com/1643261

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/rubyonrails-talk/-/9nw3zUSoK50J.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.

Thanks a lot.

I maked some improvments =>

#verifications/index.haml
- if Ad.unverified_ads.size == 0
- else
  = link_to "Fast Verify", 
fast_verify_info_verification_path(Ad.unverified_ads.last), :method => 
:put
= link_to "Normal Verify", verify_info_verification_path(ad), :method
=>
:put

#verifications/verify_info.haml
= link_to "Verify", verify_verification_path(@ad)

#verifications/fast_verify_info.haml
= link_to "Verify", 
fast_verify_verification_path(Ad.unverified_ads.last), :method => :put

#verification_controller.rb
  def verify_info
    @ad = Ad.find(params[:id])
  end

  def fast_verify_info
    @ad = Ad.find(params[:id])
  end

  def fast_verify
    @ad = Ad.find(params[:id])
    @ad.verify!
    if Ad.unverified_ads.size == 0
      redirect_to verifications_path
    else
    redirect_to 
fast_verify_info_verification_path(Ad.unverified_ads.last)
    end
  end

  def verify
    @ad = Ad.find(params[:id])
    @ad.verify!
    if params[:fast] == true
      redirect_to Ad.unverified_ads.last
    else
    redirect_to verifications_path
    end
  end

-- 
Posted via http://www.ruby-forum.com/.

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.