Rails - May 2011 - Execute after_save callback only if an attribute is modified

for instance if I want to fetch a url if the url attribute has
changed.

I know that I can use before_save and do:

def get_url
  get_url if url_changed?
end

However, this is not really correct. If that call is using delayed job
or some other technique since the object is not yet saved in the
before_save callback, for instance.

def get_url
  Queue.add(:fetch_url, id)
end

might end up getting the old URL if it is executed before the update
completes. The prior technique would also end up using the new URL if
the update fails. This is the sort of thing that should be done after
the object is updated.

I''d like to do something like:

after_save :get_url, :if => url_changed?

but this won''t work because the url is no longer "dirty"
after the
save.

Settings flags in the before_save and executing after_save gets ugly
real fast, and has potential for infinite loops, requiring hackery.

Is there a clean way to do this?



-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.

On May 23, 5:10 pm, Alex N <a...-g95NU89ilgTQT0dZR+AlfA@public.gmane.org>
wrote:
> I''d like to do something like:
>
> after_save :get_url, :if => url_changed?
>
> but this won''t work because the url is no longer "dirty"
after the
> save.
Have you tried this? Unless something''s broken, the dirty attributes
shouldn''t be cleared until *after* all the callbacks run.

--Matt Jones

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.

My bad.  You are correct. I''m not sure why I thought otherwise, but I
did a simple test and the flags are indeed not cleared until after all
the callbacks are run. Sorry for the confusion - must have been a
different bug.

On May 24, 4:42 am, Matt Jones
<al2o...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
wrote:
> On May 23, 5:10 pm, Alex N
<a...-g95NU89ilgTQT0dZR+AlfA@public.gmane.org> wrote:
>
> > I''d like to do something like:
>
> > after_save :get_url, :if => url_changed?
>
> > but this won''t work because the url is no longer
"dirty" after the
> > save.
>
> Have you tried this? Unless something''s broken, the dirty
attributes
> shouldn''t be cleared until *after* all the callbacks run.
>
> --Matt Jones
-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.