Rails - Apr 2006 - Possible acts_as_authenticated bug (or rails)

The code that comes with the plugin uses a method that looks like this:

def password_required?
    crypted_password.blank? or not password.blank?
 end

with validations that look like this:

  validates_presence_of     :password,                   :if =>
:password_required?
  validates_presence_of     :password_confirmation,      :if =>
:password_required?
  validates_length_of       :password, :within => 5..40, :if =>
:password_required?
  validates_confirmation_of :password,                   :if =>
:password_required?

I though the validations_presence_of :password_confirmation was a bit
redundant, so I removed it. Unfortunately, that breaks the
password_required? method. Here''s how I fixed it:

def password_required?
    logger.debug(''hi'')
    crypted_password.blank? or not password.blank?
end

I added a debug statement, that''s it. What am I missing?

And why do I still need check the presence of the confirmation field,
isn''t that the purpose of validates_confirmation_of?

Thanks,
PJ

I had a problem with this method as well, but it was a while ago and the
exact details escape me at the moment..  I was only playing and my site
wasn''t ever going into production.

The way I got around was to remove the not condition on password.blank? in
the password_required? method.

I don''t know the ramifications of this I never really studied it much
but it
allowed me to continue to play.

If someone out there knows what impact this has I would surely like to hear.

Cheer

On 4/26/06, PJ Hyett <pjhyett@gmail.com> wrote:
>
> The code that comes with the plugin uses a method that looks like this:
>
> def password_required?
>     crypted_password.blank? or not password.blank?
> end
>
> with validations that look like this:
>
>   validates_presence_of     :password,                   :if =>
> :password_required?
>   validates_presence_of     :password_confirmation,      :if =>
> :password_required?
>   validates_length_of       :password, :within => 5..40, :if =>
> :password_required?
>   validates_confirmation_of :password,                   :if =>
> :password_required?
>
> I though the validations_presence_of :password_confirmation was a bit
> redundant, so I removed it. Unfortunately, that breaks the
> password_required? method. Here''s how I fixed it:
>
> def password_required?
>     logger.debug(''hi'')
>     crypted_password.blank? or not password.blank?
> end
>
> I added a debug statement, that''s it. What am I missing?
>
> And why do I still need check the presence of the confirmation field,
> isn''t that the purpose of validates_confirmation_of?
>
> Thanks,
> PJ
> _______________________________________________
> Rails mailing list
> Rails@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://wrath.rubyonrails.org/pipermail/rails/attachments/20060427/51ca56b0/attachment-0001.html