Rails - Apr 2005 - Coding Standard for New Adapter

Morning Everyone......

I''m looking for a little advice on what the best method is to handle
some work I''m doing in my effort to create an activerecord adapter for
Firebird.

Among other changes, Firebird doesn''t like the concept of "column
NULL" it only accepts "column IS NULL" meaning that I''ve
had to make a
fair number of changes to functions within the associations area.

What I''m wondering is whether or not it''s appropriate to make
the
changes in the base files or should I alias the original methods in the
adapter and then override the original methods in the adapter and call
the aliased function if it''s not a call coming from my adapter - for
example

alias original_func func

def func()
	if not firebird
		original_func
	else
		my modified func
	end
end

I''m just not sure which would be the better option. I''m not
sure all the
changes belong in the original files - but I can imagine it looking just
as strange if someone gets an error in "original_func" and has no clue
what this strange function is because I''m aliasing it in my adapter.

I hope this makes some sense to the folks who have the knowledge :)

John W Higgins
develop-U23jnKMpDSxBDgjK7y7TUQ@public.gmane.org

I can''t say that I have knowledge of the adapter, but from a SQL 
standard point of view, "IS NULL" is the correct usage. NULL != NULL, 
because NULL''s value is undefined. Most databases allow the other 
construct rather than try to teach their users what NULL actually means, 
but any supported database will handle "IS NULL", so I would think
this
should be something that can be changed in the base files...

John W Higgins wrote:
>Morning Everyone......
>
>I''m looking for a little advice on what the best method is to
handle
>some work I''m doing in my effort to create an activerecord adapter
for
>Firebird.
>
>Among other changes, Firebird doesn''t like the concept of
"column >NULL" it only accepts "column IS NULL" meaning
that I''ve had to make a
>fair number of changes to functions within the associations area.
>
>What I''m wondering is whether or not it''s appropriate to
make the
>changes in the base files or should I alias the original methods in the
>adapter and then override the original methods in the adapter and call
>the aliased function if it''s not a call coming from my adapter -
for
>example
>
>alias original_func func
>
>def func()
>	if not firebird
>		original_func
>	else
>		my modified func
>	end
>end
>
>I''m just not sure which would be the better option. I''m
not sure all the
>changes belong in the original files - but I can imagine it looking just
>as strange if someone gets an error in "original_func" and has no
clue
>what this strange function is because I''m aliasing it in my
adapter.
>
>I hope this makes some sense to the folks who have the knowledge :)
>
>John W Higgins
>develop-U23jnKMpDSxBDgjK7y7TUQ@public.gmane.org
>
>_______________________________________________
>Rails mailing list
>Rails-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org
>http://lists.rubyonrails.org/mailman/listinfo/rails
>
>
>  
>