Rails core - Jun 2010 - [patch] fix bytesize in exception template; multibyte titleize

Hi all,

I wanted to draw some attention to a couple of very small multibyte-related
patches I believe should be included before Rails 3.0 RC1:

* Use String#bytesize rather than String#length in exception templates:

This is a simple case where string length is checked, but bytes is needed,
so it breaks with string with multibyte chars.

https://rails.lighthouseapp.com/projects/8994/tickets/4727-use-rackutilsbytesize-instead-of-length-when-determining-request-content-length-for-showing-exceptions

* Add AS::Multibyte::Chars#titleize

This makes "café".mb_chars.titleize "do the right thing," in
the sprit of a
few other patches I recently submitted.

https://rails.lighthouseapp.com/projects/8994/tickets/2794-titleize-missing-in-activesupportmultibytechars

I realize Railsconf is going on (I''m here!) but I thought it might be
good
to point these two out before it''s too late.

Regards,

Norman

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.

Any chance somebody could take a quick look at these? I think they''re
worth
including before the release candidate.

On Wed, Jun 9, 2010 at 12:26, Norman Clarke <norman@njclarke.com> wrote:
> Hi all,
>
> I wanted to draw some attention to a couple of very small multibyte-related
> patches I believe should be included before Rails 3.0 RC1:
>
> * Use String#bytesize rather than String#length in exception templates:
>
> This is a simple case where string length is checked, but bytes is needed,
> so it breaks with string with multibyte chars.
>
>
>
https://rails.lighthouseapp.com/projects/8994/tickets/4727-use-rackutilsbytesize-instead-of-length-when-determining-request-content-length-for-showing-exceptions
>
> * Add AS::Multibyte::Chars#titleize
>
> This makes "café".mb_chars.titleize "do the right
thing," in the sprit of a
> few other patches I recently submitted.
>
>
>
https://rails.lighthouseapp.com/projects/8994/tickets/2794-titleize-missing-in-activesupportmultibytechars
>
> I realize Railsconf is going on (I''m here!) but I thought it might
be good
> to point these two out before it''s too late.
>
> Regards,
>
> Norman
>
>
>
-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.