Rails core - Jun 2008 - ActiveSupport::Dependencies does not exist on branch

This commit seems to have broken the stable 2-1 branch:
http://github.com/rails/rails/commit/cce30f71246dbc5433153156afa4f952553ad13d

I think it should not have been committed to the branch because on the
branch lib/active_support/dependencies.rb does not yet have its module
namespace wrapped with the ActiveSupport namespace (looks like that''s
only on the trunk). fwiw, I''m looking at this version of
dependencies.rb
http://github.com/rails/rails/tree/cce30f71246dbc5433153156afa4f952553ad13d/activesupport/lib/active_support/dependencies.rb

Am I confused here? When I look at the dependencies.rb file on the
tree attached to that commit it looks like it does not have the
ActiveSupport namespace wrapped around it, but I''m hesitant to call it
a bug because it seems like this would have been picked up in the
simplest of tests (it fails for me on loading script/console).

Cheers,

Andrew
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

p.s. running: "git revert cce30f71246dbc5433153156afa4f952553ad13d"
fixes the problem.

On Jun 9, 1:35 pm, acechase <acech...@gmail.com>
wrote:
> This commit seems to have broken the stable 2-1
branch:http://github.com/rails/rails/commit/cce30f71246dbc5433153156afa4f952...
>
> I think it should not have been committed to the branch because on the
> branch lib/active_support/dependencies.rb does not yet have its module
> namespace wrapped with the ActiveSupport namespace (looks like
that''s
> only on the trunk). fwiw, I''m looking at this version of
>
dependencies.rbhttp://github.com/rails/rails/tree/cce30f71246dbc5433153156afa4f95255...
>
> Am I confused here? When I look at the dependencies.rb file on the
> tree attached to that commit it looks like it does not have the
> ActiveSupport namespace wrapped around it, but I''m hesitant to
call it
> a bug because it seems like this would have been picked up in the
> simplest of tests (it fails for me on loading script/console).
>
> Cheers,
>
> Andrew
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

I posted on this a few days back and also created a ticket:

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/331

- rob

http://robsanheim.com


On Mon, Jun 9, 2008 at 4:37 PM, acechase <acechase@gmail.com>
wrote:
>
> p.s. running: "git revert
cce30f71246dbc5433153156afa4f952553ad13d"
> fixes the problem.
>
> On Jun 9, 1:35 pm, acechase <acech...@gmail.com> wrote:
>> This commit seems to have broken the stable 2-1
branch:http://github.com/rails/rails/commit/cce30f71246dbc5433153156afa4f952...
>>
>> I think it should not have been committed to the branch because on the
>> branch lib/active_support/dependencies.rb does not yet have its module
>> namespace wrapped with the ActiveSupport namespace (looks like
that''s
>> only on the trunk). fwiw, I''m looking at this version of
>>
dependencies.rbhttp://github.com/rails/rails/tree/cce30f71246dbc5433153156afa4f95255...
>>
>> Am I confused here? When I look at the dependencies.rb file on the
>> tree attached to that commit it looks like it does not have the
>> ActiveSupport namespace wrapped around it, but I''m hesitant to
call it
>> a bug because it seems like this would have been picked up in the
>> simplest of tests (it fails for me on loading script/console).
>>
>> Cheers,
>>
>> Andrew
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On Mon, Jun 9, 2008 at 2:40 PM, Rob Sanheim <rsanheim@gmail.com>
wrote:
>
> I posted on this a few days back and also created a ticket:
>
> http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/331
Thanks for the heads-up, guys. Josh merged the missing commits over to
2-1-stable.

jeremy

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---