Over on ruby on rails talk, Eric Ly noted that partial counters now begin at 1 instead of 0. As far as I can tell this is because previously the counter value came straight out of each_with_index. However now the PartialTemplate starts off with a counter value of 0 and we += it before the render. Unfortunately it doesn''t look like there was a test for this in 2.0 so it''s not surprising this snuck through. Can it be put back to the way it was or is the disruption of it changing a second time in 2.1.x more trouble than it''s worth? Fred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> Can it be put back to the way it was or is the disruption of it > changing a second time in 2.1.x more trouble than it''s worth?Yeah, it should be reverted to start at zero just like it used to. Open a lighthouse ticket for it and we''ll get it into 2.1.1 -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 3 Jun 2008, at 19:40, Michael Koziarski wrote:> >> Can it be put back to the way it was or is the disruption of it >> changing a second time in 2.1.x more trouble than it''s worth? > > Yeah, it should be reverted to start at zero just like it used to. > Open a lighthouse ticket for it and we''ll get it into 2.1.1 >did that here: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/344-partial-counters-start-from-1-in-2-1 Fred> > -- > Cheers > > Koz > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---