I just noticed I frequently encounter patches that need to be updated because of applied changes. Maybe this can be automated? Not automating the "updating of the patch" part, but the part where a comment is posted to the ticket so the submitter is informed. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 10/24/07, mikong <michaelgalero@gmail.com> wrote:> > > I just noticed I frequently encounter patches that need to be updated > because of applied changes. Maybe this can be automated? Not > automating the "updating of the patch" part, but the part where a > comment is posted to the ticket so the submitter is informed.Pratik made an application a while ago that checks if a patch applies cleanly: http://rails.corefun.org/ Full automation is possible in theory but hard to do in practice. Are you suggesting that some script goes through all patches on Trac after eachcommit to Rails trunk and checks if they still apply cleanly? That would be one heck of a post-commit hook. The idea is not bad, however. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> Are you > suggesting that some script goes through all patches on Trac after each > commit to Rails trunk and checks if they still apply cleanly? That would be > one heck of a post-commit hook. The idea is not bad, however.I know the SvK guys have talked about building something like this into RT. But it just seems like you''d end up building a half-assed DSCM tool... We already have the stale tickets report, the odds of the patches on that list applying are pretty slim. http://dev.rubyonrails.org/report/69 If you feel like closing some old patches / reports, that''s where to find them. -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
I was actually thinking of limiting the script to check only the recent patches (no use checking patches made years ago), and it doesn''t have to be run on every commit. But then how recent and how frequently is it run? I don''t really have any criteria for this. Full automation doesn''t seem to be worth pursuing further. Thanks for all the info. Though I wish I had access to Pratik''s app :) On Oct 24, 1:41 pm, "Michael Koziarski" <mich...@koziarski.com> wrote:> > Are you > > suggesting that some script goes through all patches on Trac after each > > commit to Rails trunk and checks if they still apply cleanly? That would be > > one heck of a post-commit hook. The idea is not bad, however. > > I know the SvK guys have talked about building something like this > into RT. But it just seems like you''d end up building a half-assed > DSCM tool... > > We already have the stale tickets report, the odds of the patches on > that list applying are pretty slim. > > http://dev.rubyonrails.org/report/69 > > If you feel like closing some old patches / reports, that''s where to find them. > > -- > Cheers > > Koz--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
It''s a hack done in few hours. No one dare to laugh ;-) http://tools.assembla.com/svn/corefun On 10/25/07, mikong <michaelgalero@gmail.com> wrote:> > I was actually thinking of limiting the script to check only the > recent patches (no use checking patches made years ago), and it > doesn''t have to be run on every commit. But then how recent and how > frequently is it run? I don''t really have any criteria for this. Full > automation doesn''t seem to be worth pursuing further. Thanks for all > the info. > > Though I wish I had access to Pratik''s app :) > > On Oct 24, 1:41 pm, "Michael Koziarski" <mich...@koziarski.com> wrote: > > > Are you > > > suggesting that some script goes through all patches on Trac after each > > > commit to Rails trunk and checks if they still apply cleanly? That would be > > > one heck of a post-commit hook. The idea is not bad, however. > > > > I know the SvK guys have talked about building something like this > > into RT. But it just seems like you''d end up building a half-assed > > DSCM tool... > > > > We already have the stale tickets report, the odds of the patches on > > that list applying are pretty slim. > > > > http://dev.rubyonrails.org/report/69 > > > > If you feel like closing some old patches / reports, that''s where to find them. > > > > -- > > Cheers > > > > Koz > > > > >-- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Thanks :) On Oct 25, 9:37 am, Pratik <pratikn...@gmail.com> wrote:> It''s a hack done in few hours. No one dare to laugh ;-) > > http://tools.assembla.com/svn/corefun > > On 10/25/07, mikong <michaelgal...@gmail.com> wrote: > > > > > > > I was actually thinking of limiting the script to check only the > > recent patches (no use checking patches made years ago), and it > > doesn''t have to be run on every commit. But then how recent and how > > frequently is it run? I don''t really have any criteria for this. Full > > automation doesn''t seem to be worth pursuing further. Thanks for all > > the info. > > > Though I wish I had access to Pratik''s app :) > > > On Oct 24, 1:41 pm, "Michael Koziarski" <mich...@koziarski.com> wrote: > > > > Are you > > > > suggesting that some script goes through all patches on Trac after each > > > > commit to Rails trunk and checks if they still apply cleanly? That would be > > > > one heck of a post-commit hook. The idea is not bad, however. > > > > I know the SvK guys have talked about building something like this > > > into RT. But it just seems like you''d end up building a half-assed > > > DSCM tool... > > > > We already have the stale tickets report, the odds of the patches on > > > that list applying are pretty slim. > > > >http://dev.rubyonrails.org/report/69 > > > > If you feel like closing some old patches / reports, that''s where to find them. > > > > -- > > > Cheers > > > > Koz > > -- > Cheers! > - Pratikhttp://m.onkey.org--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---