Rails core - Oct 2007 - rails:freeze:edge task is broken [updating to 2.0]

On 10/3/07, Glenn Rempe <glenn.rempe@gmail.com>
wrote:
>
>
> You may want to also take a look at this bug report that I filed.  I
> had the same problem and running the ''rake rails:freeze:edge
> TAG=rel_2-0-0_PR'' TWO times resolved the issue for me when
upgrading a
> 1.2.3 app.  Explanation in the bug report.
>
> http://dev.rubyonrails.org/ticket/9743

Thanks, Glenn.

To everyone: I''ve been wanting to bring this issue up for a long time
now,
but always keep forgetting. Everyone knows by now that AWS has been replaced
by ActiveResource. This change in framework requirements broke the
freeze:edge task for reasons already discussed. The questions I want to
bring up are:

   1. Are we going to "fix" this in Rails 2.0 Initializer (ie. make it
   not whine about missing ARes)?
   2. If the Initializer is not going to change, should we be telling
   users that the preferred way of fixing this issue is running the freeze task
   twice?
   3. Are we going to do something about this for the future (however
   unlikely changing the frameworks again might be)?

It''s a shame that this error message is so daunting and misleading. I
feel
sorry for all those people already wasting hours trying to figure out what
is wrong.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

> Are we going to "fix" this in Rails 2.0 Initializer (ie. make it
not whine
> about missing ARes)?
This seems reasonable, it will at least stop hurting people when we
next release from trunk.
> If the Initializer is not going to change, should we be telling users that
> the preferred way of fixing this issue is running the freeze task twice?
Running a freeze from 1.2.4 will get the right components.
Unfortunately 2.0PR1 landed before 1.2.4 did.
> Are we going to do something about this for the future (however unlikely
> changing the frameworks again might be)?It''s a shame that this
error message
> is so daunting and misleading. I feel sorry for all those people already
> wasting hours trying to figure out what is wrong.
If we''d pushed 1.2.4 before 2.0pr1 then user''s would have had
a safe
upgrade which pointed out a few of these things.  I think that''s a
safe approach for the future, unless I''m missing something.

-- 
Cheers

Koz

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 10/3/07, Michael Koziarski <michael@koziarski.com>
wrote:
>
>
> > Are we going to "fix" this in Rails 2.0 Initializer (ie.
make it not
> whine
> > about missing ARes)?
>
> This seems reasonable, it will at least stop hurting people when we
> next release from trunk.

The biggest problem is the misleading error message and stack trace.
I''ve
investigated, and it turns out Mongrel swallows LoadErrors raised in
Rails::Initializer. (Don''t ask me why.) After it swallows the error,
something happens that pushes the Rails 1.2.3 gem into load paths,
"commands/servers/mongrel.rb" gets re-loaded from the wrong place and
the
whole thing crashes miserably.

Koz, please see my patch:
http://dev.rubyonrails.org/attachment/ticket/9743/require-frameworks.diff

It doesn''t make Rails tolerate LoadErrors in require_frameworks.
Without
ARes, starting Mongrel will still fail, but at least with this patch users
will get the proper error message and stack trace about not being able to
load ARes.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---