Jake
2011-Aug-17 21:44 UTC
[Puppet Users] facter-1.6.0 incorrectly identifies hardware node as virtual
I''ve installed facter-1.6.0 and puppet-2.7.3 on a number of SLES 10 hardware nodes (HP DL580) running the Virtuozzo hosting software. Well, facter correctly identifies such a machine as a hardware node ("virtual => openvzhn") but somehow concludes that the hardware node is in fact virtual. ("is_virtual => true") This breaks some rather important logic. If anyone knows of a patch floating around out there for 1.6.0 I''d be obliged. Even better would be to get this officially fixed for facter-1.6.1. Joe -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
Dan Carley
2011-Aug-18 08:53 UTC
Re: [Puppet Users] facter-1.6.0 incorrectly identifies hardware node as virtual
On 17 August 2011 22:44, Jake <jake@mainphrame.com> wrote:> I''ve installed facter-1.6.0 and puppet-2.7.3 on a number of SLES 10 > hardware nodes (HP DL580) running the Virtuozzo hosting software. > > Well, facter correctly identifies such a machine as a hardware node > ("virtual => openvzhn") but somehow concludes that the hardware node > is in fact virtual. ("is_virtual => true") > > This breaks some rather important logic. If anyone knows of a patch > floating around out there for 1.6.0 I''d be obliged. Even better would > be to get this officially fixed for facter-1.6.1. >You can try this: https://gist.github.com/1153679 To get it fixed in the next release you''ll need to file an issue over at: http://projects.puppetlabs.com/projects/facter -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
Florian Koch
2011-Aug-18 09:11 UTC
[Puppet Users] Re: facter-1.6.0 incorrectly identifies hardware node as virtual
On Aug 17, 11:44 pm, Jake <j...@mainphrame.com> wrote:> I''ve installed facter-1.6.0 and puppet-2.7.3 on a number of SLES 10 > hardware nodes (HP DL580) running the Virtuozzo hosting software. > > Well, facter correctly identifies such a machine as a hardware node > ("virtual => openvzhn") but somehow concludes that the hardware node > is in fact virtual. ("is_virtual => true") > > This breaks some rather important logic. If anyone knows of a patch > floating around out there for 1.6.0 I''d be obliged. Even better would > be to get this officially fixed for facter-1.6.1. > > JoeHi, i have had the same trouble with puppet 2.6.9 and facter 1.6.0 i changed the if $ist_virtual{..} to if $is_virtual == ''true'' {...} and now it works again. flo -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
Florian Koch
2011-Aug-18 09:43 UTC
[Puppet Users] Re: facter-1.6.0 incorrectly identifies hardware node as virtual
On Aug 17, 11:44 pm, Jake <j...@mainphrame.com> wrote:> I''ve installed facter-1.6.0 and puppet-2.7.3 on a number of SLES 10 > hardware nodes (HP DL580) running the Virtuozzo hosting software. > > Well, facter correctly identifies such a machine as a hardware node > ("virtual => openvzhn") but somehow concludes that the hardware node > is in fact virtual. ("is_virtual => true") > > This breaks some rather important logic. If anyone knows of a patch > floating around out there for 1.6.0 I''d be obliged. Even better would > be to get this officially fixed for facter-1.6.1. > > JoeHi, i have had the same problem with puppet 2.6.9 and facter 1.6.0 i change if $is_virtual{...} to if $is_virtual == ''true'' {...} and it works again as expected. flo -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
Jake
2011-Aug-18 17:38 UTC
[Puppet Users] Re: facter-1.6.0 incorrectly identifies hardware node as virtual
Excellent, thanks - patch applied here with good results. It appears the issue is already known as of facter-1.5.9: http://projects.puppetlabs.com/issues/7957 So, the ball should already be rolling on this one - right? Jake On Aug 18, 1:53 am, Dan Carley <dan.car...@gmail.com> wrote:> On 17 August 2011 22:44, Jake <j...@mainphrame.com> wrote: > > > I''ve installed facter-1.6.0 and puppet-2.7.3 on a number of SLES 10 > > hardware nodes (HP DL580) running the Virtuozzo hosting software. > > > Well, facter correctly identifies such a machine as a hardware node > > ("virtual => openvzhn") but somehow concludes that the hardware node > > is in fact virtual. ("is_virtual => true") > > > This breaks some rather important logic. If anyone knows of a patch > > floating around out there for 1.6.0 I''d be obliged. Even better would > > be to get this officially fixed for facter-1.6.1. > > You can try this:https://gist.github.com/1153679 > > To get it fixed in the next release you''ll need to file an issue over at:http://projects.puppetlabs.com/projects/facter-- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
Dan Carley
2011-Aug-22 08:11 UTC
Re: [Puppet Users] Re: facter-1.6.0 incorrectly identifies hardware node as virtual
On 18 August 2011 18:38, Jake <jake@mainphrame.com> wrote:> Excellent, thanks - patch applied here with good results. > > It appears the issue is already known as of facter-1.5.9: > http://projects.puppetlabs.com/issues/7957 > > So, the ball should already be rolling on this one - right? >I missed that in my brief search. I''ve commented with said patch and unit tests. Should be fixed upstream in the future. -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.