Paul Andreassen
2007-Oct-05 06:06 UTC
Re: [puppet] #829: Multiple source with recursion error
On Friday 05 October 2007 03:54, puppet wrote:> #829: Multiple source with recursion error > -----------------------------+--------------------------------------------- >- Reporter: paul | Owner: michael > Type: defect | Status: closed > Priority: normal | Milestone: unplanned > Component: library | Version: > Severity: normal | Resolution: fixed > Keywords: pfile | Stage: Accepted > Approval: Unnecessary | Patch: Code > Complexity: Unknown | Compatibility: Unknown > Specification: Unnecessary | > -----------------------------+--------------------------------------------- >- Changes (by luke): > > * status: assigned => closed > * resolution: => fixed > > Comment: > > I applied your patch in [9236179fadf5d0ee68abab395ba1102cd04f3471], but I > could neither get a test written to expose the bug nor figure out from > looking at the code how it could actually cause a problem, because the > ''source'' variable is not used again in the block, so it getting reassigned > couldn''t actually have an impact.The ''source'' variable is used again in the desc.split("\n") loop. If a file follows a directory when using mulitple sources, the last @parameters[:source] replaces the correct source.> Either way, it''s an innocent-enough patch and it certainly was a coding > bug, so I applied it. Hopefully it fixes your problem, anyway.Yes, it should fix the problem, thanks, Paul
On Oct 5, 2007, at 1:06 AM, Paul Andreassen wrote:>> >> I applied your patch in >> [9236179fadf5d0ee68abab395ba1102cd04f3471], but I >> could neither get a test written to expose the bug nor figure out >> from >> looking at the code how it could actually cause a problem, >> because the >> ''source'' variable is not used again in the block, so it getting >> reassigned >> couldn''t actually have an impact. > > The ''source'' variable is used again in the desc.split("\n") loop. > If a file > follows a directory when using mulitple sources, the last > @parameters[:source] replaces the correct source.Ahhh, I see. Thanks. -- Football is a mistake. It combines the two worst elements of American life. Violence and committee meetings. -- George F. Will --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com