Lepton Wu
2011-Jan-10 08:48 UTC
[Pkg-xen-devel] Bug#609517: xen-utils-3.2-1: Pygrub can't find grub.conf in a reiserfs partion on amd64 arch
Package: xen-utils-3.2-1
Version: 3.2.1-2
Severity: normal
Tags: patch
Hi,
There is a bug xen-3-3.2.1/tools/libfsimage/reiserfs/fsys_reiserfs.c,
it is using "unsigned long" which is 64 bits on amd64 arch and 32
bits on i386 arch.
This makes pygrub can't work on reiserfs on amd64 arch. You can easily
reproduce it.
A patch is included for fixing this problem.
diff -ur xen-3-3.2.1/tools/libfsimage/reiserfs/fsys_reiserfs.c
xen-3-3.2.1-lepton/tools/libfsimage/reiserfs/fsys_reiserfs.c
--- xen-3-3.2.1/tools/libfsimage/reiserfs/fsys_reiserfs.c 2008-05-12
19:01:57.000000000 +0800
+++ xen-3-3.2.1-lepton/tools/libfsimage/reiserfs/fsys_reiserfs.c 2011-01-10
16:37:38.000000000 +0800
@@ -222,7 +222,7 @@
struct disk_child
{
- unsigned long dc_block_number; /* Disk child's block
number. */
+ unsigned int dc_block_number; /* Disk child's block
number. */
unsigned short dc_size; /* Disk child's used space.
*/
};
-- System Information:
Debian Release: 5.0.7
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-2-xen-amd64 (SMP w/4 CPU cores)
Locale: LANG=zh_CN, LC_CTYPE=zh_CN (charmap=GB2312)
Shell: /bin/sh linked to /bin/bash
Versions of packages xen-utils-3.2-1 depends on:
ii e2fslibs 1.41.3-1 ext2 filesystem libraries
ii iproute 20080725-2 networking and traffic control too
ii libc6 2.7-18lenny6 GNU C Library: Shared libraries
ii libgcrypt11 1.4.1-1 LGPL Crypto library - runtime libr
ii libgnutls26 2.4.2-6+lenny2 the GNU TLS library - runtime libr
ii libncurses5 5.7+20081213-1 shared libraries for terminal hand
ii libsdl1.2debian 1.2.13-2 Simple DirectMedia Layer
ii libxenstore3.0 3.2.1-2 Xenstore communications library fo
ii python 2.5.2-3 An interactive high-level object-o
ii python-central 0.6.8 register and build utility for Pyt
ii udev 0.125-7+lenny3 /dev/ and hotplug management daemo
ii xen-utils-common 3.2.0-2 XEN administrative tools - common
ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime
Versions of packages xen-utils-3.2-1 recommends:
ii bridge-utils 1.4-5 Utilities for configuring the Linu
ii xen-hypervisor-3.2-1-amd64 [x 3.2.1-2 The Xen Hypervisor on AMD64
Versions of packages xen-utils-3.2-1 suggests:
pn xen-docs-3.2 <none> (no description available)
-- debconf-show failed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-64-bits-issue.diff
Type: text/x-diff
Size: 619 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20110110/dc104f1d/attachment.diff>
Ian Campbell
2011-Jan-10 10:10 UTC
[Pkg-xen-devel] Bug#609517: Bug#609517: xen-utils-3.2-1: Pygrub can't find grub.conf in a reiserfs partion on amd64 arch
FYI this was fixed by 20716:d3411ed9bd02 in xen-unstable. The fix was present in the 4.0.0 release. Ian. On Mon, 2011-01-10 at 16:48 +0800, Lepton Wu wrote:> Package: xen-utils-3.2-1 > Version: 3.2.1-2 > Severity: normal > Tags: patch > > Hi, > > There is a bug xen-3-3.2.1/tools/libfsimage/reiserfs/fsys_reiserfs.c, > it is using "unsigned long" which is 64 bits on amd64 arch and 32 > bits on i386 arch. > This makes pygrub can't work on reiserfs on amd64 arch. You can easily > reproduce it. > A patch is included for fixing this problem. > > diff -ur xen-3-3.2.1/tools/libfsimage/reiserfs/fsys_reiserfs.c xen-3-3.2.1-lepton/tools/libfsimage/reiserfs/fsys_reiserfs.c > --- xen-3-3.2.1/tools/libfsimage/reiserfs/fsys_reiserfs.c 2008-05-12 19:01:57.000000000 +0800 > +++ xen-3-3.2.1-lepton/tools/libfsimage/reiserfs/fsys_reiserfs.c 2011-01-10 16:37:38.000000000 +0800 > @@ -222,7 +222,7 @@ > > struct disk_child > { > - unsigned long dc_block_number; /* Disk child's block number. */ > + unsigned int dc_block_number; /* Disk child's block number. */ > unsigned short dc_size; /* Disk child's used space. */ > }; > > > > -- System Information: > Debian Release: 5.0.7 > APT prefers stable > APT policy: (500, 'stable') > Architecture: amd64 (x86_64) > > Kernel: Linux 2.6.26-2-xen-amd64 (SMP w/4 CPU cores) > Locale: LANG=zh_CN, LC_CTYPE=zh_CN (charmap=GB2312) > Shell: /bin/sh linked to /bin/bash > > Versions of packages xen-utils-3.2-1 depends on: > ii e2fslibs 1.41.3-1 ext2 filesystem libraries > ii iproute 20080725-2 networking and traffic control too > ii libc6 2.7-18lenny6 GNU C Library: Shared libraries > ii libgcrypt11 1.4.1-1 LGPL Crypto library - runtime libr > ii libgnutls26 2.4.2-6+lenny2 the GNU TLS library - runtime libr > ii libncurses5 5.7+20081213-1 shared libraries for terminal hand > ii libsdl1.2debian 1.2.13-2 Simple DirectMedia Layer > ii libxenstore3.0 3.2.1-2 Xenstore communications library fo > ii python 2.5.2-3 An interactive high-level object-o > ii python-central 0.6.8 register and build utility for Pyt > ii udev 0.125-7+lenny3 /dev/ and hotplug management daemo > ii xen-utils-common 3.2.0-2 XEN administrative tools - common > ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime > > Versions of packages xen-utils-3.2-1 recommends: > ii bridge-utils 1.4-5 Utilities for configuring the Linu > ii xen-hypervisor-3.2-1-amd64 [x 3.2.1-2 The Xen Hypervisor on AMD64 > > Versions of packages xen-utils-3.2-1 suggests: > pn xen-docs-3.2 <none> (no description available) > > -- debconf-show failed > _______________________________________________ > Pkg-xen-devel mailing list > Pkg-xen-devel at lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/pkg-xen-devel-- Ian Campbell Current Noise: She Said Destroy - Becoming The Morningstar Neutrinos are into physicists.