Ovirt devel - Mar 2010 - [PATCH node] Fix reboot issue

Reboots were not working correctly due the use of "stop" when
stopping services.  It resulted in the reboot process dying.

See https://bugzilla.redhat.com/show_bug.cgi?id=519366 for details.

Signed-off-by: Mike Burns <mburns at redhat.com>
---
 scripts/ovirt           |    2 +-
 scripts/ovirt-firstboot |    2 +-
 scripts/ovirt-post      |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/ovirt b/scripts/ovirt
index 3059d35..752564a 100755
--- a/scripts/ovirt
+++ b/scripts/ovirt
@@ -114,7 +114,7 @@ case "$1" in
         start
         ;;
     stop)
-        stop
+        rm -f /var/lock/subsys/ovirt
         ;;
     *)
         echo "Usage: ovirt {start}"
diff --git a/scripts/ovirt-firstboot b/scripts/ovirt-firstboot
index 58847f4..7717a50 100755
--- a/scripts/ovirt-firstboot
+++ b/scripts/ovirt-firstboot
@@ -98,7 +98,7 @@ case "$1" in
         start
         ;;
     stop)
-        stop
+         rm -f /var/lock/subsys/ovirt-firstboot
         ;;
     *)
         echo "Usage: ovirt-firstboot {start}"
diff --git a/scripts/ovirt-post b/scripts/ovirt-post
index 16af387..f53157a 100755
--- a/scripts/ovirt-post
+++ b/scripts/ovirt-post
@@ -107,7 +107,7 @@ case "$1" in
         start
         ;;
     stop)
-        stop
+        rm -f /var/lock/subsys/ovirt-post
         ;;
     *)
         echo "Usage: ovirt-post {start}"
-- 
1.6.6.1

On Wed, Mar 10, 2010 at 9:32 PM, Mike Burns <mburns at redhat.com>
wrote:
> Reboots were not working correctly due the use of "stop" when
> stopping services. ?It resulted in the reboot process dying.
issue was that stop() was not defined in those scripts, so stop was
actually upstart's initctl stop
> See https://bugzilla.redhat.com/show_bug.cgi?id=519366 for details.
>
> Signed-off-by: Mike Burns <mburns at redhat.com>
> ---
> ?scripts/ovirt ? ? ? ? ? | ? ?2 +-
> ?scripts/ovirt-firstboot | ? ?2 +-
> ?scripts/ovirt-post ? ? ?| ? ?2 +-
ACK