Ovirt devel - Jul 2009 - [PATCH] Rename qmf-libvirt-example to libvirt-list.rb

This patch renames qmf-libvirt-example to libvirt-list and makes it
not repeat.  Useful for debugging.  File mode is also now 755.

Signed-off-by: Ian Main <imain at redhat.com>
---
 src/libvirt-list.rb        |   65 +++++++++++++++++++++++++++++++++++++++
 src/qmf-libvirt-example.rb |   72 --------------------------------------------
 2 files changed, 65 insertions(+), 72 deletions(-)
 create mode 100755 src/libvirt-list.rb
 delete mode 100644 src/qmf-libvirt-example.rb

diff --git a/src/libvirt-list.rb b/src/libvirt-list.rb
new file mode 100755
index 0000000..54e8b7e
--- /dev/null
+++ b/src/libvirt-list.rb
@@ -0,0 +1,65 @@
+#!/usr/bin/ruby
+
+$: << File.join(File.dirname(__FILE__), "./dutils")
+
+require "rubygems"
+require "qpid"
+require "dutils"
+
+get_credentials('qpidd')
+
+server, port = get_srv('qpidd', 'tcp')
+raise "Unable to determine qpid server from DNS SRV record" if not
server
+
+srv = "amqp://#{server}:#{port}"
+puts "Connecting to #{srv}.."
+s = Qpid::Qmf::Session.new()
+b = s.add_broker(srv, :mechanism => 'GSSAPI')
+
+nodes = s.objects(:class => "node")
+nodes.each do |node|
+    puts "node: #{node.hostname}"
+    for (key, val) in node.properties
+        puts "  property: #{key}, #{val}"
+    end
+
+    # Find any domains that on the current node.
+    domains = s.objects(:class => "domain", 'node' =>
node.object_id)
+    domains.each do |domain|
+        r = domain.getXMLDesc()
+        puts "getXMLDesc() status: #{r.status}"
+        puts "getXMLDesc() status: #{r.text}"
+        if r.status == 0
+            puts "xml length: #{r.description.length}"
+        end
+
+        puts "  domain: #{domain.name}, state: #{domain.state}, id:
#{domain.id}"
+        for (key, val) in domain.properties
+            puts "    property: #{key}, #{val}"
+        end
+    end
+
+    pools = s.objects(:class => "pool", 'node' =>
node.object_id)
+    pools.each do |pool|
+        puts "  pool: #{pool.name}"
+        for (key, val) in pool.properties
+            puts "    property: #{key}, #{val}"
+        end
+
+        r = pool.getXMLDesc()
+        puts "getXMLDesc() status: #{r.status}"
+        puts "getXMLDesc() text: #{r.text}"
+        if r.status == 0
+            puts "xml length: #{r.description.length}"
+        end
+
+        # Find volumes that are part of the pool.
+        volumes = s.objects(:class => "volume", 'pool'
=> pool.object_id)
+        volumes.each do |volume|
+            puts "    volume: #{volume.name}"
+            for (key, val) in volume.properties
+                puts "      property: #{key}, #{val}"
+            end
+        end
+    end
+end
diff --git a/src/qmf-libvirt-example.rb b/src/qmf-libvirt-example.rb
deleted file mode 100644
index 7e01ffb..0000000
--- a/src/qmf-libvirt-example.rb
+++ /dev/null
@@ -1,72 +0,0 @@
-#!/usr/bin/ruby
-
-$: << File.join(File.dirname(__FILE__), "./dutils")
-
-require "rubygems"
-require "qpid"
-require "dutils"
-
-get_credentials('qpidd')
-
-server, port = get_srv('qpidd', 'tcp')
-raise "Unable to determine qpid server from DNS SRV record" if not
server
-
-srv = "amqp://#{server}:#{port}"
-puts "Connecting to #{srv}.."
-s = Qpid::Qmf::Session.new()
-b = s.add_broker(srv, :mechanism => 'GSSAPI')
-
-while true:
-    nodes = s.objects(:class => "node")
-    nodes.each do |node|
-        puts "node: #{node.hostname}"
-        for (key, val) in node.properties
-            puts "  property: #{key}, #{val}"
-        end
-
-        # Find any domains that on the current node.
-        domains = s.objects(:class => "domain", 'node'
=> node.object_id)
-        domains.each do |domain|
-            r = domain.getXMLDesc()
-            puts "getXMLDesc() status: #{r.status}"
-            puts "getXMLDesc() status: #{r.text}"
-            if r.status == 0
-                puts "xml length: #{r.description.length}"
-            end
-
-            puts "  domain: #{domain.name}, state: #{domain.state}, id:
#{domain.id}"
-            for (key, val) in domain.properties
-                puts "    property: #{key}, #{val}"
-            end
-        end
-
-        pools = s.objects(:class => "pool", 'node' =>
node.object_id)
-        pools.each do |pool|
-            puts "  pool: #{pool.name}"
-            for (key, val) in pool.properties
-                puts "    property: #{key}, #{val}"
-            end
-
-            r = pool.getXMLDesc()
-            puts "getXMLDesc() status: #{r.status}"
-            puts "getXMLDesc() text: #{r.text}"
-            if r.status == 0
-                puts "xml length: #{r.description.length}"
-            end
-
-            # Find volumes that are part of the pool.
-            volumes = s.objects(:class => "volume", 'pool'
=> pool.object_id)
-            volumes.each do |volume|
-                puts "    volume: #{volume.name}"
-                for (key, val) in volume.properties
-                    puts "      property: #{key}, #{val}"
-                end
-            end
-        end
-
-    end
-
-    puts '----------------------------'
-    sleep(5)
-
-end
-- 
1.6.0.6

On Wed, 2009-07-15 at 11:50 -0700, Ian Main wrote:
> This patch renames qmf-libvirt-example to libvirt-list and makes it
> not repeat.  Useful for debugging.  File mode is also now 755.
> 
> Signed-off-by: Ian Main <imain at redhat.com>
Looks fine to me, though it would be cleaner to do the rename with git
mv, and the other changes as an additional patch.

Shouldn't this ultimately go into libvirt-qpid ? There's really nothing
ovirt specific about the script.

David