Ovirt devel - Jul 2009 - [PATCH node] display network interface driver name and MAC 2.

add header with column description
---
 scripts/ovirt-config-networking |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/scripts/ovirt-config-networking b/scripts/ovirt-config-networking
index 8380187..e10ed12 100755
--- a/scripts/ovirt-config-networking
+++ b/scripts/ovirt-config-networking
@@ -351,19 +351,18 @@ else
         printf "Configuring the network will destroy any existing
networking\n"
         printf "configuration on this system.\n"
         printf "***** WARNING *****\n"
-        pixied=false
+        printf "\nPhysical Networking Devices (*=PXE boot
interface)\n"
+        printf "Name\tDriver\tMAC\n"
         for nic in $NICS; do
             driver=$(basename $(readlink /sys/class/net/$nic/device/driver))
             mac=$(cat /sys/class/net/$nic/address)
             if [ "$nic" = "$OVIRT_BOOTIF" ]; then
-                nic="*$nic"
-                pixied=true
+                pxe="*"
+            else
+                pxe=" "
             fi
-            printf "%s\t%s\t%s\n" $nic $driver $mac
+            printf "%s%s\t%s\t%s\n" $pxe $nic $driver $mac
         done
-        if $pixied; then
-            printf "*=PXE boot interface\n"
-        fi
 
         DNS="DNS"
         NTP="NTP"
-- 
1.6.0.6

On Fri, Jul 10, 2009 at 11:27:08PM +0200, Alan Pevec
wrote:
> add header with column description
> ---
>  scripts/ovirt-config-networking |   13 ++++++-------
>  1 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/ovirt-config-networking
b/scripts/ovirt-config-networking
> index 8380187..e10ed12 100755
> --- a/scripts/ovirt-config-networking
> +++ b/scripts/ovirt-config-networking
> @@ -351,19 +351,18 @@ else
>          printf "Configuring the network will destroy any existing
networking\n"
>          printf "configuration on this system.\n"
>          printf "***** WARNING *****\n"
> -        pixied=false
> +        printf "\nPhysical Networking Devices (*=PXE boot
interface)\n"
> +        printf "Name\tDriver\tMAC\n"
>          for nic in $NICS; do
>              driver=$(basename $(readlink
/sys/class/net/$nic/device/driver))
>              mac=$(cat /sys/class/net/$nic/address)
>              if [ "$nic" = "$OVIRT_BOOTIF" ]; then
> -                nic="*$nic"
> -                pixied=true
> +                pxe="*"
> +            else
> +                pxe=" "
>              fi
> -            printf "%s\t%s\t%s\n" $nic $driver $mac
> +            printf "%s%s\t%s\t%s\n" $pxe $nic $driver $mac
>          done
> -        if $pixied; then
> -            printf "*=PXE boot interface\n"
> -        fi
>  
>          DNS="DNS"
>          NTP="NTP"
> -- 
> 1.6.0.6
ACK.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste n? B?arla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20090710/389a9d50/attachment.sig>