Marcus Asteborg
2020-Apr-10 17:31 UTC
[opus] Opus CMake build support for Apple frameworks
Hi Simon,
CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS
https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos
Can you clarify what your patch does?
//Marcus
cmake-toolchains(7) — CMake 3.14.7
Documentation<https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos>
The CMAKE_SYSTEM_NAME is the CMake-identifier of the target platform to build
for.. The CMAKE_SYSTEM_PROCESSOR is the CMake-identifier of the target
architecture to build for.. The CMAKE_SYSROOT is optional, and may be specified
if a sysroot is available.. The CMAKE_STAGING_PREFIX is also optional. It may be
used to specify a path on the host to install to. The CMAKE_INSTALL_PREFIX is
always ...
cmake.org
________________________________
From: opus <opus-bounces at xiph.org> on behalf of opus-request at
xiph.org <opus-request at xiph.org>
Sent: Friday, April 10, 2020 05:00
To: opus at xiph.org <opus at xiph.org>
Subject: opus Digest, Vol 132, Issue 5
Send opus mailing list submissions to
opus at xiph.org
To subscribe or unsubscribe via the World Wide Web, visit
https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0
or, via email, send a message with subject or body 'help' to
opus-request at xiph.org
You can reach the person managing the list at
opus-owner at xiph.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of opus digest..."
Today's Topics:
1. Opus CMake build support for Apple frameworks (Simon Jackson)
----------------------------------------------------------------------
Message: 1
Date: Thu, 9 Apr 2020 16:59:54 +0100
From: Simon Jackson <simon.jackson at sonocent.com>
To: opus at xiph.org
Subject: [opus] Opus CMake build support for Apple frameworks
Message-ID:
<CAAZh+M2BzPMvB6=U-LcAOZmSK_1phySrTRWGG9UhcMDWjf5Txw at
mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi,
I've put together a patch which adds support to the CMake build for
building Apple frameworks, as much as I dislike them. Is this something
you'd like to integrate?
Thanks,
Simon
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.html&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=nIeHaWLowLksYl9QQvV1y2Rkd3zvUGiuqfIUYHknHnw%3D&reserved=0>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opus_cmake_frameworks.patch
Type: application/octet-stream
Size: 2793 bytes
Desc: not available
URL:
<https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.obj&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=d5V%2BTOGF3Onv6FJiFXlksuCLdf2Q5XKhqpQ8VsANw%2BU%3D&reserved=0>
------------------------------
Subject: Digest Footer
_______________________________________________
opus mailing list
opus at xiph.org
https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0
------------------------------
End of opus Digest, Vol 132, Issue 5
************************************
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20200410/587e5a29/attachment.html>
Hi Marcus, When building shared libraries for macOS / iOS /tvOS, by default `.dylib` shared libraries will be generated. With this patch `BUILD_FRAMEWORK` is exposed as an option allowing the user to specify that a `.framework` bundle should be built instead of a standalone `.dylib` file. Enabling the option sets the necessary target properties to instruct CMake to do this. The Ogg CMake build already has this functionality, this patch should be consistent with how frameworks are handled there. Simon On Fri, 10 Apr 2020 at 18:32, Marcus Asteborg <xnorpx at outlook.com> wrote:> Hi Simon, > > CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS > > > https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos > > Can you clarify what your patch does? > > //Marcus > cmake-toolchains(7) — CMake 3.14.7 Documentation > <https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos> > The CMAKE_SYSTEM_NAME is the CMake-identifier of the target platform to > build for.. The CMAKE_SYSTEM_PROCESSOR is the CMake-identifier of the > target architecture to build for.. The CMAKE_SYSROOT is optional, and may > be specified if a sysroot is available.. The CMAKE_STAGING_PREFIX is also > optional. It may be used to specify a path on the host to install to. The > CMAKE_INSTALL_PREFIX is always ... > cmake.org > > > ------------------------------ > *From:* opus <opus-bounces at xiph.org> on behalf of opus-request at xiph.org < > opus-request at xiph.org> > *Sent:* Friday, April 10, 2020 05:00 > *To:* opus at xiph.org <opus at xiph.org> > *Subject:* opus Digest, Vol 132, Issue 5 > > Send opus mailing list submissions to > opus at xiph.org > > To subscribe or unsubscribe via the World Wide Web, visit > > https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0 > or, via email, send a message with subject or body 'help' to > opus-request at xiph.org > > You can reach the person managing the list at > opus-owner at xiph.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of opus digest..." > > > Today's Topics: > > 1. Opus CMake build support for Apple frameworks (Simon Jackson) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Thu, 9 Apr 2020 16:59:54 +0100 > From: Simon Jackson <simon.jackson at sonocent.com> > To: opus at xiph.org > Subject: [opus] Opus CMake build support for Apple frameworks > Message-ID: > <CAAZh+M2BzPMvB6> U-LcAOZmSK_1phySrTRWGG9UhcMDWjf5Txw at mail.gmail.com> > Content-Type: text/plain; charset="utf-8" > > Hi, > > I've put together a patch which adds support to the CMake build for > building Apple frameworks, as much as I dislike them. Is this something > you'd like to integrate? > > Thanks, > Simon > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.html&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=nIeHaWLowLksYl9QQvV1y2Rkd3zvUGiuqfIUYHknHnw%3D&reserved=0 > > > -------------- next part -------------- > A non-text attachment was scrubbed... > Name: opus_cmake_frameworks.patch > Type: application/octet-stream > Size: 2793 bytes > Desc: not available > URL: < > https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.obj&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=d5V%2BTOGF3Onv6FJiFXlksuCLdf2Q5XKhqpQ8VsANw%2BU%3D&reserved=0 > > > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > opus mailing list > opus at xiph.org > > https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0 > > > ------------------------------ > > End of opus Digest, Vol 132, Issue 5 > ************************************ > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20200414/094ab6ce/attachment.html>
Marcus Asteborg
2020-Apr-14 14:49 UTC
[opus] Opus CMake build support for Apple frameworks
Hi Simon,
Please create a pull request here: https://github.com/xnorpx/opus/pulls
Also please add a buildconfig here that exercise the BUILD_FRAMEWORK option:
https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml
[https://avatars2.githubusercontent.com/u/302709?s=400&v=4]<https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml>
xnorpx/opus<https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml>
Modern audio compression for the internet. Contribute to xnorpx/opus development
by creating an account on GitHub.
github.com
That way we can ensure the patch work as expected and doesn't break any
exciting behavior.
Best Regards Marcus
________________________________
From: Simon Jackson <simon.jackson at sonocent.com>
Sent: Tuesday, April 14, 2020 02:12
To: Marcus Asteborg <xnorpx at outlook.com>
Cc: opus at xiph.org <opus at xiph.org>
Subject: Re: [opus] Opus CMake build support for Apple frameworks
Hi Marcus,
When building shared libraries for macOS / iOS /tvOS, by default `.dylib` shared
libraries will be generated. With this patch `BUILD_FRAMEWORK` is exposed as an
option allowing the user to specify that a `.framework` bundle should be built
instead of a standalone `.dylib` file. Enabling the option sets the necessary
target properties to instruct CMake to do this.
The Ogg CMake build already has this functionality, this patch should be
consistent with how frameworks are handled there.
Simon
On Fri, 10 Apr 2020 at 18:32, Marcus Asteborg <xnorpx at
outlook.com<mailto:xnorpx at outlook.com>> wrote:
Hi Simon,
CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS
https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcmake.org%2Fcmake%2Fhelp%2Fv3.14%2Fmanual%2Fcmake-toolchains.7.html%23cross-compiling-for-ios-tvos-or-watchos&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564086078&sdata=0Bw0x9ZDBfsROuP4Dil7Fb4MPs29DQiV2Y%2F7V1j6zwE%3D&reserved=0>
Can you clarify what your patch does?
//Marcus
cmake-toolchains(7) — CMake 3.14.7
Documentation<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcmake.org%2Fcmake%2Fhelp%2Fv3.14%2Fmanual%2Fcmake-toolchains.7.html%23cross-compiling-for-ios-tvos-or-watchos&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564096059&sdata=s85t4wULfxV5mLOcheTvhV%2Bel%2BQd1uZlr5kF0z9WyCw%3D&reserved=0>
The CMAKE_SYSTEM_NAME is the CMake-identifier of the target platform to build
for.. The CMAKE_SYSTEM_PROCESSOR is the CMake-identifier of the target
architecture to build for.. The CMAKE_SYSROOT is optional, and may be specified
if a sysroot is available.. The CMAKE_STAGING_PREFIX is also optional. It may be
used to specify a path on the host to install to. The CMAKE_INSTALL_PREFIX is
always ...
cmake.org<https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcmake.org%2F&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564106041&sdata=34JR5LY1Gpsbx2TE9jBB1OcnAYo6BSrRE3VQ4aomiyE%3D&reserved=0>
________________________________
From: opus <opus-bounces at xiph.org<mailto:opus-bounces at
xiph.org>> on behalf of opus-request at xiph.org<mailto:opus-request at
xiph.org> <opus-request at xiph.org<mailto:opus-request at
xiph.org>>
Sent: Friday, April 10, 2020 05:00
To: opus at xiph.org<mailto:opus at xiph.org> <opus at
xiph.org<mailto:opus at xiph.org>>
Subject: opus Digest, Vol 132, Issue 5
Send opus mailing list submissions to
opus at xiph.org<mailto:opus at xiph.org>
To subscribe or unsubscribe via the World Wide Web, visit
https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0<https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564116025&sdata=KqIRU3pSXaanAqPMb7A8fGwp9k9q77o%2FHL6hRreFrRM%3D&reserved=0>
or, via email, send a message with subject or body 'help' to
opus-request at xiph.org<mailto:opus-request at xiph.org>
You can reach the person managing the list at
opus-owner at xiph.org<mailto:opus-owner at xiph.org>
When replying, please edit your Subject line so it is more specific
than "Re: Contents of opus digest..."
Today's Topics:
1. Opus CMake build support for Apple frameworks (Simon Jackson)
----------------------------------------------------------------------
Message: 1
Date: Thu, 9 Apr 2020 16:59:54 +0100
From: Simon Jackson <simon.jackson at sonocent.com<mailto:simon.jackson at
sonocent.com>>
To: opus at xiph.org<mailto:opus at xiph.org>
Subject: [opus] Opus CMake build support for Apple frameworks
Message-ID:
<CAAZh+M2BzPMvB6=U-LcAOZmSK_1phySrTRWGG9UhcMDWjf5Txw at
mail.gmail.com<mailto:U-LcAOZmSK_1phySrTRWGG9UhcMDWjf5Txw at
mail.gmail.com>>
Content-Type: text/plain; charset="utf-8"
Hi,
I've put together a patch which adds support to the CMake build for
building Apple frameworks, as much as I dislike them. Is this something
you'd like to integrate?
Thanks,
Simon
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.html&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=nIeHaWLowLksYl9QQvV1y2Rkd3zvUGiuqfIUYHknHnw%3D&reserved=0<https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.html&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564126005&sdata=uNJ7JiprmEUTKx6Ef0ho1bmDyo5f0iZ2Y7xgjMWznyA%3D&reserved=0>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opus_cmake_frameworks.patch
Type: application/octet-stream
Size: 2793 bytes
Desc: not available
URL:
<https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.obj&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=d5V%2BTOGF3Onv6FJiFXlksuCLdf2Q5XKhqpQ8VsANw%2BU%3D&reserved=0<https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.obj&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564135989&sdata=bu2Z4FXmEOoSMxIKjjRDeAr6FULDJhslK4JBMZfT3KI%3D&reserved=0>>
------------------------------
Subject: Digest Footer
_______________________________________________
opus mailing list
opus at xiph.org<mailto:opus at xiph.org>
https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0<https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564145971&sdata=Vq2Ip5UFH3ugg3XEe2pXWYadL%2FuurVAD2bLjpbyk1gI%3D&reserved=0>
------------------------------
End of opus Digest, Vol 132, Issue 5
************************************
_______________________________________________
opus mailing list
opus at xiph.org<mailto:opus at xiph.org>
http://lists.xiph.org/mailman/listinfo/opus<https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564160945&sdata=mvb6hWdBK5H%2B2gpxNgV6LosVH6wGGSPR5TPK%2F4bEprg%3D&reserved=0>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20200414/5ed14d30/attachment-0001.html>