search for: xnorpx

Hi Simon, Please create a pull request here: https://github.com/xnorpx/opus/pulls Also please add a buildconfig here that exercise the BUILD_FRAMEWORK option: https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml [https://avatars2.githubusercontent.com/u/302709?s=400&v=4]<https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml&gt...

Hi all, With some downtime it's time for some CMake fixes. Most critically is the SSE fixes to avoid crashes that is described in 154 and 132 in github. Patch 5 should address this and also adding APPROX-FLOAT option. Hopefully this can give some gains for those of us running on Windows servers.j I went through the pull request and picked out a few that will ease up integration for

Did the patch 5 split / AVX fix work get merged at all, I didn't see any more mails about it? Thanks! On Tue, 14 Jan 2020 at 21:34, Marcus Asteborg <xnorpx at outlook.com> wrote: > Awesome thanks! Good comments. > > Please apply patch 1-4 and I prepare another iteration on patch 5 for you > too look at. > > //Marcus > ------------------------------ > *From:* Jean-Marc Valin <jmvalin at jmvalin.ca> > *Sent:* Tuesday...

Hi Simon, CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos Can you clarify what your patch does? //Marcus cmake-toolchains(7) — CMake 3.14.7 Documentation<https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos> The

Sorry about that, let me check the correct version for the intrin0.h include guard. //Marcus ________________________________ From: Ralph Giles <giles at thaumas.net> Sent: Thursday, June 11, 2020 19:31 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Speaking of needing more complete ci feedback, the intrin0.h patch broke the appveyor build: > Microsoft (R) Build Engine version 14.0.25420.1 > [...] > :\projects\opus\celt\ecintrin.h(53): fat...

...CMAKE_BUILD_TYPE one has to specify CMAKE_BUILD_TYPE and export the CFLAGS https://github.com/xiph/opus/pull/118 [https://avatars0.githubusercontent.com/u/8365509?s=400&v=4]<https://github.com/xiph/opus/pull/118> CMake - If CMAKE_BUILD_TYPE is empty and CFlags are set then only use… by xnorpx · Pull Request #118 · xiph/opus<https://github.com/xiph/opus/pull/118> CMake - If CMAKE_BUILD_TYPE is empty and CFlags are set then only use CFlags. If None are set then use CMAKE_BUILD_TYPE by Release by default. github.com //Marcus ________________________________ From: Cristian Adam <...

Hi, Here is a patch to add build instructions for CMake to the README. * I tried to follow the previous automake style instructions as closely as possible but added instructions for Windows. * Noted that it is still experimental //Marcus -------------- next part -------------- An HTML attachment was scrubbed... URL:

On Wed, Apr 10, 2019 at 5:30 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > Hi Mark, > > Thanks for the feedback. > > By default CMake is building the static library in debug, to get other > things one has to explicit turn it on. > > Hi, By default CMake uses the "empty" build, which is used in combination wit...

Verified that intrin0.h was available in 1910, by building it locally on VS2017 version 15.0 MSVC++ 14.1 _MSC_VER == 1910 (Visual Studio 2017 version 15.0) https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B //Marcus ________________________________ From: Marcus Asteborg <xnorpx at outlook.com> Sent: Thursday, June 11, 2020 20:15 To: Ralph Giles <giles at thaumas.net>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Sorry about that, let me check the correct version for the intrin0.h include guard. //Marcus ____________________________...

>>> Marcus Asteborg <xnorpx at outlook.com> schrieb am 24.06.2020 um 19:59 in Nachricht <8175_1593021574_5EF39486_8175_1287_1_DB3PR0602MB378816E9B5FC531496C4CE9FDF950 at D 3PR0602MB3788.eurprd06.prod.outlook.com>: > > ________________________________ > From: Mark Harris <mark.hsj at gmail.com> > S...

3, no good catch attached is an updated patch //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Thursday, June 11, 2020 10:49 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches On 2020-06-08 01:39, Marcus Asteborg wrote: > 1. Build test for cmake and run the test in gitlab-ci. OK, merged. > 2. Disable the message box on Windows on abort that cause test hangs in CI. M...

Hi, Here are 3 suggested patches. 1. Build test for cmake and run the test in gitlab-ci. 2. Disable the message box on Windows on abort that cause test hangs in CI. 3. Build time improvement by removing unnecessary includes of stdio.h in production code and change to a lighter header intrin.h -> intrin0.h (windows only). Attached screenshot of measurement but it resulted in 14%

...and updated when Visual Studio is updated. For related discussion about CMake support see https://github.com/xiph/opus/pull/37 For any concerns, comments or questions regarding the change please comment in the pull request, reply to this thread or send me an e-mail. Builds and tests: https://xnorpx.visualstudio.com/opus%20build/_build/results?buildId=135 Related Issue: https://github.com/xiph/opus/issues/85 Best Regards Marcus Asteborg -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20181205/f3fc84d9/att...

...Hub<https://github.com/features/actions> GitHub is where people build software. More than 40 million people use GitHub to discover, fork, and contribute to over 100 million projects. github.com I attached the patch to get it building and I am already building it on my fork: https://github.com/xnorpx/opus/commit/a6a7bf81e155b267159d86a76fc84ffc2c14c100/checks?check_suite_id=402591586 It will build desktop flavors of CMake and also build the same configurations as TRAVIS-CI builds with AutoMake. So my proposal is to remove the Travis-CI build and replace with github actions instead. Work is b...

On Sat, Jun 13, 2020 at 2:59 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > > Hi, > > Here is a patch to add build instructions for CMake to the README. > > I tried to follow the previous automake style instructions as closely as possible but added instructions for Windows. > Noted that it is still experimental > > //M...

________________________________ From: Mark Harris <mark.hsj at gmail.com> Sent: Wednesday, June 24, 2020 00:09 To: Marcus Asteborg <xnorpx at outlook.com> Cc: opus at xiph.org <opus at xiph.org> Subject: Re: Add CMake build instructions to README > Hi Marcus, > Currently the build instructions start with simple instructions for > building from the release tarball, and then provide more complex > alternative inst...

...of a standalone `.dylib` file. Enabling the option sets the necessary target properties to instruct CMake to do this. The Ogg CMake build already has this functionality, this patch should be consistent with how frameworks are handled there. Simon On Fri, 10 Apr 2020 at 18:32, Marcus Asteborg <xnorpx at outlook.com> wrote: > Hi Simon, > > CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS > > > https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos > > Can you clarify what your patch does? > > //Ma...

I tried the new cmake-based build system to build Opus on Linux and macOS. I'm not familiar with cmake but based on instructions I found online I used it as follows: - mkdir build - cd build - cmake -DCMAKE_INSTALL_PREFIX:PATH=<install-path> .. - make - ctest - make install Although the "make" command completed, it reported that optimizations were disabled:

Right that I had completely missed, I have added the files and verified that it builds with CMake from the tar on Linux (out of the git repo) I am parsing the package_version file from the tarball if it exists so it should maintain the version info. //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Tuesday, April 2, 2019 11:38 To: Marcus

Hi, Here is a patch to update documentation to Doxygen 1.8.18 as the navbar is broken trying to use the latest Doxygen. Also seems we are missing documentation for last releases here: https://www.opus-codec.org/docs/ Best Regards Marcus -------------- next part -------------- An HTML attachment was scrubbed... URL: