Hello Jean-Marc et all, I've attached an updated patch which I feel addresses all 3 cases. PTAL, Thanks! Cheers, Drew On Wed, Mar 7, 2018 at 8:39 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:> Make sure the modified libraries work in all of these three cases: > 1) libopus 1.2.1 > 2) libopus master (or 1.3-beta) with --enable-ambisonics > 3) libopus master (or 1.3-beta) with --disable-ambisonics > > I suspect with the current set of patches you might have problems with > case 3) since you will find the symbols in the header file, but the > functionality won't be there. > > Cheers, > > Jean-Marc > > On 03/07/2018 02:40 PM, Drew Allen wrote: > > Move demixing matrix defines to opus_define to better determine > > availability of Projection API. > > > > Allows libopusenc, opusfile and opus-tools to much more easily determine > > availability of Projection API. > > > > Cheers, > > Drew > > > > > > _______________________________________________ > > opus mailing list > > opus at xiph.org > > http://lists.xiph.org/mailman/listinfo/opus > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20180308/1bd79961/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: libopus-Allow-users.patch Type: text/x-patch Size: 5561 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/opus/attachments/20180308/1bd79961/attachment.bin>
Hi Drew, I think the idea of returning OPUS_UNIMPLEMENTED for all projection encoder/decoder calls is pretty reasonable. I haven't looked in detail, but I think some of the calls are missing. I think all calls should have that behaviour and not just the ones used by libopusenc. As for the includes, how about leaving OPUS_PROJECTION_*_REQUEST in opus_projection.h, but defining OPUS_HAVE_OPUS_PROJECTION_H (or something like that) in opus.h? I still haven't looked at your libopusenc changes, that's my next step. Cheers, Jean-Marc On 03/08/2018 06:43 PM, Drew Allen wrote:> Hello Jean-Marc et all, > > I've attached an updated patch which I feel addresses all 3 cases. > > PTAL, Thanks! > > Cheers, > Drew > > On Wed, Mar 7, 2018 at 8:39 PM Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > Make sure the modified libraries work in all of these three cases: > 1) libopus 1.2.1 > 2) libopus master (or 1.3-beta) with --enable-ambisonics > 3) libopus master (or 1.3-beta) with --disable-ambisonics > > I suspect with the current set of patches you might have problems with > case 3) since you will find the symbols in the header file, but the > functionality won't be there. > > Cheers, > > Jean-Marc > > On 03/07/2018 02:40 PM, Drew Allen wrote: > > Move demixing matrix defines to opus_define to better determine > > availability of Projection API. > > > > Allows libopusenc, opusfile and opus-tools to much more easily > determine > > availability of Projection API. > > > > Cheers, > > Drew > > > > > > _______________________________________________ > > opus mailing list > > opus at xiph.org <mailto:opus at xiph.org> > > http://lists.xiph.org/mailman/listinfo/opus > > >
Thanks Jean-Marc! I'm alittle under the weather today but I'll address your comments tomorrow. Feel free to wait on my patch for libopusenc until tomorrow as well, as I will have a new patch sent out then. Cheers, Drew Cheers, Drew On Mon, Mar 12, 2018 at 10:06 AM, Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:> Hi Drew, > > I think the idea of returning OPUS_UNIMPLEMENTED for all projection > encoder/decoder calls is pretty reasonable. I haven't looked in detail, > but I think some of the calls are missing. I think all calls should have > that behaviour and not just the ones used by libopusenc. > > As for the includes, how about leaving > OPUS_PROJECTION_*_REQUEST in opus_projection.h, but defining > OPUS_HAVE_OPUS_PROJECTION_H (or something like that) in opus.h? > > I still haven't looked at your libopusenc changes, that's my next step. > > Cheers, > > Jean-Marc > > On 03/08/2018 06:43 PM, Drew Allen wrote: > > Hello Jean-Marc et all, > > > > I've attached an updated patch which I feel addresses all 3 cases. > > > > PTAL, Thanks! > > > > Cheers, > > Drew > > > > On Wed, Mar 7, 2018 at 8:39 PM Jean-Marc Valin <jmvalin at jmvalin.ca > > <mailto:jmvalin at jmvalin.ca>> wrote: > > > > Make sure the modified libraries work in all of these three cases: > > 1) libopus 1.2.1 > > 2) libopus master (or 1.3-beta) with --enable-ambisonics > > 3) libopus master (or 1.3-beta) with --disable-ambisonics > > > > I suspect with the current set of patches you might have problems > with > > case 3) since you will find the symbols in the header file, but the > > functionality won't be there. > > > > Cheers, > > > > Jean-Marc > > > > On 03/07/2018 02:40 PM, Drew Allen wrote: > > > Move demixing matrix defines to opus_define to better determine > > > availability of Projection API. > > > > > > Allows libopusenc, opusfile and opus-tools to much more easily > > determine > > > availability of Projection API. > > > > > > Cheers, > > > Drew > > > > > > > > > _______________________________________________ > > > opus mailing list > > > opus at xiph.org <mailto:opus at xiph.org> > > > http://lists.xiph.org/mailman/listinfo/opus > > > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20180312/39a77b04/attachment.html>