search for: opus_project

Hello Jean-Marc et all, I've attached an updated patch which I feel addresses all 3 cases. PTAL, Thanks! Cheers, Drew On Wed, Mar 7, 2018 at 8:39 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Make sure the modified libraries work in all of these three cases: > 1) libopus 1.2.1 > 2) libopus master (or 1.3-beta) with --enable-ambisonics > 3) libopus master (or

...B. Terriberry <tterribe at xiph.org> wrote: > Drew Allen wrote: > >> Please feel free to ask any questions or give any feedback you might >> have. :) >> > > A few comments from a quick glance through the opusfile patch: > > You unconditionally #include <opus_projection.h> in the public header, but > you haven't updated the libopus version requirement in configure.ac. > Ideally, of course, libopusfile would continue to work with older versions > of libopus, just with a reduced feature set. The best would be if libopus > itself provided a #def...

thanks for all your feedback. here's the revised patch: On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org> wrote: > Jean-Marc Valin wrote: > > I think you'll want something like: > > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8) > > (though you might want to check it too) > > FWIW, we use the construct > int s =

Hello all, Attached are patches for libopusenc, opusfile and opus-tools in order to provide support for Ambisonics and the Projection API for encoding/decoding channel mapping 253 and 254. Please feel free to ask any questions or give any feedback you might have. :) Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL:

...s a merge conflict. > > 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT > is only meant for functions exposed to the API (and in the include/ > directory), but I see several of these in mapping_matrix.h, which I > think is incorrect. > > Done. > 3) opus_projection_ambisonics_encoder_init() (which should be > OPUS_EXPORT) is missing from opus_projection.h > > Done. > 4) I believe mapping_matrix_get_size() should be returning > align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_int16) > rather than: > align(sizeof(MappingMatrix)...

...tl() can also be removed by adding another ctl() macro (like _oge_ctl()) with an extra argument. In the case of OPUS_MULTISTREAM_GET_ENCODER_STATE_REQUEST, you can simply use _oge_ctl(enc->st, OPUS_MULTISTREAM_GET_ENCODER_STATE(stream_id, value)) 3) On libopus itself, why "#define OPUS_HAVE_OPUS_PROJECTION_H 9000" instead of just "#define OPUS_HAVE_OPUS_PROJECTION_H"? Cheers, Jean-Marc On 03/19/2018 02:53 PM, Drew Allen wrote: > > On Mon, Mar 19, 2018 at 11:52 AM Drew Allen <bitllama at google.com > <mailto:bitllama at google.com>> wrote: > > Hel...

...ea of returning OPUS_UNIMPLEMENTED for all projection encoder/decoder calls is pretty reasonable. I haven't looked in detail, but I think some of the calls are missing. I think all calls should have that behaviour and not just the ones used by libopusenc. As for the includes, how about leaving OPUS_PROJECTION_*_REQUEST in opus_projection.h, but defining OPUS_HAVE_OPUS_PROJECTION_H (or something like that) in opus.h? I still haven't looked at your libopusenc changes, that's my next step. Cheers, Jean-Marc On 03/08/2018 06:43 PM, Drew Allen wrote: > Hello Jean-Marc et all, > > I&...

On Mon, Jul 9, 2018 at 9:39 PM, Joshua Bowman <silverbacknet at gmail.com> wrote: > Most projects don't even bother to include *.vcxproj.filters, relying on > cmake or default behavior, but since it'd be referenced in there, sure, I > think so. Want an updated patch? Sure, preferably in "git format-patch" format. - Mark

...ion(h->channel_mapping)) + { + len=27+(h->channels*(h->nb_streams+h->nb_coupled)*2); + } + else + { + len=27+h->channels; + } The fixed part of the header is 19 bytes; where does the 27 come from here? +struct OpusGenericEncoder { + OpusMSEncoder *ms; +#ifdef OPUS_HAVE_OPUS_PROJECTION_H + OpusProjectionEncoder *pr; +#endif + int family; +}; opus_multistream.h needs to be included for OpusMSEncoder. opus_projection.h can't be relied upon to include it since opus_projection.h may not be available. +OpusGenericEncoder *_oge_surround_create( + int Fs, int channels, in...

..._EXPORT declarations. > OPUS_EXPORT > > is only meant for functions exposed to the API (and in the include/ > > directory), but I see several of these in mapping_matrix.h, which I > > think is incorrect. > > > > Done. > > > > > > 3) opus_projection_ambisonics_encoder_init() (which should be > > OPUS_EXPORT) is missing from opus_projection.h > > > > Done. > > > > > > 4) I believe mapping_matrix_get_size() should be returning > > align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_in...

Drew Allen wrote: > Please feel free to ask any questions or give any feedback you might > have. :) A few comments from a quick glance through the opusfile patch: You unconditionally #include <opus_projection.h> in the public header, but you haven't updated the libopus version requirement in configure.ac. Ideally, of course, libopusfile would continue to work with older versions of libopus, just with a reduced feature set. The best would be if libopus itself provided a #define that its use...

...eld was removed some time ago), but can you confirm/fix the issue? 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT is only meant for functions exposed to the API (and in the include/ directory), but I see several of these in mapping_matrix.h, which I think is incorrect. 3) opus_projection_ambisonics_encoder_init() (which should be OPUS_EXPORT) is missing from opus_projection.h 4) I believe mapping_matrix_get_size() should be returning align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_int16) rather than: align(sizeof(MappingMatrix) + rows * cols * sizeof(opus_int16)) to ma...

...2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT > is only meant for functions exposed to the API (and in the include/ > directory), but I see several of these in mapping_matrix.h, which I > think is incorrect. > > Done. >   > > 3) opus_projection_ambisonics_encoder_init() (which should be > OPUS_EXPORT) is missing from opus_projection.h > > Done. >   > > 4) I believe mapping_matrix_get_size() should be returning > align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_int16) > rather than: >...

...ctory), but I see several of these in > mapping_matrix.h, > >     which I > >     >     think is incorrect. > >     > > >     > Done. > >     >   > >     > > >     >     3) opus_projection_ambisonics_encoder_init() (which > should be > >     >     OPUS_EXPORT) is missing from opus_projection.h > >     > > >     > Done. > >     >   > >     > > >     >     4) I believe ma...

...> > think is incorrect. > > > > > > > > > > Done. > > > > > > > > > > > > > > > 3) > > opus_projection_ambisonics_encoder_init() (which > > > should be > > > > > OPUS_EXPORT) is missing from > opus_projection.h > > > > > > > > > > Done. > > >...

...which I > >         >     >     think is incorrect. > >         >     > > >         >     > Done. > >         >     >   > >         >     > > >         >     >     3) > opus_projection_ambisonics_encoder_init() (which > >         should be > >         >     >     OPUS_EXPORT) is missing from opus_projection.h > >         >     > > >         >     > Done. > >         >     >   >...

...think is incorrect. >> > > > > >> > > > > Done. >> > > > > >> > > > > >> > > > > 3) >> > opus_projection_ambisonics_encoder_init() (which >> > > should be >> > > > > OPUS_EXPORT) is missing from >> opus_projection.h >> > > > > >> > > > > Done. >&...

...>         >         >     > > >         >         >     > Done. > >         >         >     >   > >         >         >     > > >         >         >     >     3) > >         opus_projection_ambisonics_encoder_init() (which > >         >         should be > >         >         >     >     OPUS_EXPORT) is missing from > opus_projection.h > >         >         >     > > >         >         > ...