search for: opus_unimplemented

...1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() changes behaviour for fixed-point and provides no guarantee about rounding. Thanks! I'll make that change. 2) About these two lines: + if (nondiegetic_channels && 2 != nondiegetic_channels) + return OPUS_UNIMPLEMENTED; Why not just have the condition be: + if (nondiegetic_channels != 2) We should allow either 0 or 2 nondiegetic channels. As a minor detail, I prefer N != 2 than 2 != N. Acknowledged. Also, unless you think it may one day make sense to have nondiegetic_channels != 2, I think you shoul...

Hello all, Attached is a proposed patch for Opus that allows support for encoding non-diegetic stereo audio as a coupled stream for use with channel mapping 254. It also rejects channel counts that are not (n+1)^2 + 2j, where n is 0 to 14 and j is either 0 or 1 (See IETF public draft doc attached for clarification). Please let me know any suggestions / concerns / comments. Thank you for your

...mments for now (not done reviewing): 1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() changes behaviour for fixed-point and provides no guarantee about rounding. 2) About these two lines: + if (nondiegetic_channels && 2 != nondiegetic_channels) + return OPUS_UNIMPLEMENTED; Why not just have the condition be: + if (nondiegetic_channels != 2) As a minor detail, I prefer N != 2 than 2 != N. Also, unless you think it may one day make sense to have nondiegetic_channels != 2, I think you should just return OPUS_BAD_ARG. OPUS_UNIMPLEMENTED is used for things that m...

...at 12:21 PM, Ralph Giles <giles at thaumas.net> wrote: > On 07/01/16 10:04 AM, Amit Ashara wrote: > > > opus_decoder_ctl(sOpusDec, OPUS_SET_LSB_DEPTH(ui32BitsPerSample)); > > OPUS_SET_LSB_DEPTH only affects the encoder. If you check the return > value here you should get OPUS_UNIMPLEMENTED. > > > output_samples = opus_decode(sOpusDec, (const unsigned char > > *)&pcRdBuf[0], len, opi16_out, (ui32SizeOfWrBuf/ui8ScaleFactor), 0); > > I suspect the issue is dividing by ui8ScaleFactor = 1 here. > OPUS_SET_LSB_DEPTH works as a precision hint to the encoder about...

Hello All I have successfully run the Opus Decoder for 16-bit WAV files. However when doing the same on 8-bit, the decoder produces noise, but on 16 bit data the output is working. Both the 8 and 16 bit files are from the same source and hence except for some loss of quality on 8 bit, they are identical in total play back duration. For both 8 and 16 bit data I have used the following parameters

...sqrt() > changes behaviour for fixed-point and provides no guarantee about > rounding. > > > Thanks! I'll make that change. > > 2) About these two lines: > + if (nondiegetic_channels && 2 != nondiegetic_channels) > + return OPUS_UNIMPLEMENTED; > > Why not just have the condition be: > + if (nondiegetic_channels != 2) > > > We should allow either 0 or 2 nondiegetic channels. > > > As a minor detail, I prefer N != 2 than 2 != N. > > > Acknowledged. > > > Also, un...

Hello Jean-Marc et all, I've attached an updated patch which I feel addresses all 3 cases. PTAL, Thanks! Cheers, Drew On Wed, Mar 7, 2018 at 8:39 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Make sure the modified libraries work in all of these three cases: > 1) libopus 1.2.1 > 2) libopus master (or 1.3-beta) with --enable-ambisonics > 3) libopus master (or

...fixed-point and provides no guarantee about > > rounding. > > > > > > Thanks! I'll make that change. > > > > 2) About these two lines: > > + if (nondiegetic_channels && 2 != nondiegetic_channels) > > + return OPUS_UNIMPLEMENTED; > > > > Why not just have the condition be: > > + if (nondiegetic_channels != 2) > > > > > > We should allow either 0 or 2 nondiegetic channels. > > > > > > As a minor detail, I prefer N != 2 than 2 != N. > > > > &g...

On 07/01/16 10:04 AM, Amit Ashara wrote: > opus_decoder_ctl(sOpusDec, OPUS_SET_LSB_DEPTH(ui32BitsPerSample)); OPUS_SET_LSB_DEPTH only affects the encoder. If you check the return value here you should get OPUS_UNIMPLEMENTED. > output_samples = opus_decode(sOpusDec, (const unsigned char > *)&pcRdBuf[0], len, opi16_out, (ui32SizeOfWrBuf/ui8ScaleFactor), 0); I suspect the issue is dividing by ui8ScaleFactor = 1 here. OPUS_SET_LSB_DEPTH works as a precision hint to the encoder about where to set the noise floo...

Hi Drew, I think the idea of returning OPUS_UNIMPLEMENTED for all projection encoder/decoder calls is pretty reasonable. I haven't looked in detail, but I think some of the calls are missing. I think all calls should have that behaviour and not just the ones used by libopusenc. As for the includes, how about leaving OPUS_PROJECTION_*_REQUEST in opus_...

...t;> On 07/01/16 10:04 AM, Amit Ashara wrote: >>>> >>>> > opus_decoder_ctl(sOpusDec, OPUS_SET_LSB_DEPTH(ui32BitsPerSample)); >>>> >>>> OPUS_SET_LSB_DEPTH only affects the encoder. If you check the return >>>> value here you should get OPUS_UNIMPLEMENTED. >>>> >>>> > output_samples = opus_decode(sOpusDec, (const unsigned char >>>> > *)&pcRdBuf[0], len, opi16_out, (ui32SizeOfWrBuf/ui8ScaleFactor), 0); >>>> >>>> I suspect the issue is dividing by ui8ScaleFactor = 1 here. >>&g...