search for: enable_asm

Viswanath Puttagunta wrote: > a. Will the approach of enabling this optimization using > --enable-armv7-neon-float or similar flag be acceptable to begin with? > > or > > b. Should the "AS_IF([test x"${enable_asm}" = x"yes"]".. section in > configure.ac be re-written? Automatic detection of compiler support in configure (in addition to run-time checks) would be preferable. We used a manual switches for, e.g., the SSE 4.2 intrinsics, just because the submitted auto-detection code w...

...ARMv8 cpu in aarch64 mode is guaranteed to have NEON/ASIMD. > >> AS_GCC_INLINE_ASSEMBLY( >> [inline_optimization="ARM"], >> [inline_optimization="disabled"] >> @@ -212,6 +211,35 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ >> AS_ASM_ARM_MEDIA([OPUS_ARM_INLINE_MEDIA=1], >> [OPUS_ARM_INLINE_MEDIA=0]) >> AS_ASM_ARM_NEON([OPUS_ARM_INLINE_NEON=1],[OPUS_ARM_INLINE_NEON=0]) >> + >> + AC_ARG_ENABLE([arm-neon-intri...

Hello, I received feedback from engineers working on NE10 [1] that it would be better to use NE10 [1] for FFT optimizations for opus use cases. However, these FFT patches are currently in review and haven't been integrated into NE10 yet. While the FFT functions in NE10 are getting baked, I wanted to optimize the celt_pitch_xcorr (floating point only) and use it to introduce ARM NEON

..._pitch_xcorr_arm.s +CELT_SOURCES_ARM_NEON_INTR = \ +celt/arm/celt_neon_intr.c + CELT_AM_SOURCES_ARM_ASM = \ celt/arm/armopts.s.in diff --git a/configure.ac b/configure.ac index 9b2f51f..09657b6 100644 --- a/configure.ac +++ b/configure.ac @@ -198,12 +198,11 @@ cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ inline_optimization="No ASM for your platform, please send patches" + OPUS_ARM_NEON_INTR_CPPFLAGS= case $host_cpu in arm*) - dnl Currently we only have asm for fixed-point - AS_IF([test "$enable_float" != "yes&q...

...xcorr, len, max_pitch)) > + xcorr, len, max_pitch, arch)) > +#endif > + And this. > diff --git a/configure.ac b/configure.ac > index 9b2f51f..09657b6 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -198,12 +198,11 @@ cpu_arm=no > > AS_IF([test x"${enable_asm}" = x"yes"],[ > inline_optimization="No ASM for your platform, please send patches" > + OPUS_ARM_NEON_INTR_CPPFLAGS= > case $host_cpu in > arm*) > - dnl Currently we only have asm for fixed-point > - AS_IF([test "$...

...instead. Signed-off-by: Peter Korsgaard <peter at korsgaard.com> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0ba4a80..443362f 100644 --- a/configure.ac +++ b/configure.ac @@ -333,9 +333,9 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ AM_CONDITIONAL([CPU_ARM], [test "$cpu_arm" = "yes"]) AM_CONDITIONAL([OPUS_ARM_INLINE_ASM], - [test x"${inline_optimization:0:3}" = x"ARM"]) + [test x"${inline_optimization%% *}" = x"ARM"]) AM_CONDITI...

configure uses invalid shell syntax. (Ah, it's a bash extension.) Here's a portable fix. --- configure.ac.orig Thu Dec 5 00:26:45 2013 +++ configure.ac Sun Dec 15 17:32:25 2013 @@ -333,9 +333,9 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ AM_CONDITIONAL([CPU_ARM], [test "$cpu_arm" = "yes"]) AM_CONDITIONAL([OPUS_ARM_INLINE_ASM], - [test x"${inline_optimization:0:3}" = x"ARM"]) + [expr x"${inline_optimization}" : x"ARM" >/dev/null])...

--- configure.ac | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/configure.ac b/configure.ac index 019d36d..13ed33f 100644 --- a/configure.ac +++ b/configure.ac @@ -199,6 +199,25 @@ cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ inline_optimization="No inline ASM for your platform, please send patches" case $host_cpu in + arm64*|aarch64*) + dnl Currently we only have asm for fixed-point + AS_IF([test "$enable_float" != "yes"],[ +...

--- configure.ac | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/configure.ac b/configure.ac index 6f61d2e..4f7ec75 100644 --- a/configure.ac +++ b/configure.ac @@ -199,6 +199,25 @@ cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ inline_optimization="No inline ASM for your platform, please send patches" case $host_cpu in + arm64*|aarch64*) + dnl Currently we only have asm for fixed-point + AS_IF([test "$enable_float" != "yes"],[ +...

...[2]. In light of this information, if and when fft implementations for 60, 120, 240, 480 become available in NE10 library, a. Will the approach of enabling this optimization using --enable-armv7-neon-float or similar flag be acceptable to begin with? or b. Should the "AS_IF([test x"${enable_asm}" = x"yes"]".. section in configure.ac be re-written? Please advise. [1]: https://code.google.com/p/webrtc/issues/detail?id=3350&can=1&q=ne10&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20Area%20Status%20Owner%20Summary [2]: https://github.com/projectNe10/Ne10 Regard...

Hi, Optimizes celt_pitch_xcorr for ARM NEON floating point. Changes from RFCv3: - celt_neon_intr.c - removed warnings due to not having constant pointers - Put simpler loop to take care of corner cases. Unrolling using intrinsics was not really mapping well to what was done in celt_pitch_xcorr_arm.s - Makefile.am Removed explicit -O3 optimization - test_unit_mathops.c,

...tack. -if ($nxstack) { +if ($nxstack && !$apple) { printf (" .section\t.note.GNU-stack,\"\",\%\%progbits\n"); } diff --git a/configure.ac b/configure.ac index 443362f..9fec105 100644 --- a/configure.ac +++ b/configure.ac @@ -317,6 +317,14 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ [rtcd_support=ARM"$rtcd_support"], [rtcd_support="no"] ) + AC_MSG_CHECKING([for apple style tools]) + AC_PREPROC_IFELSE([AC_LANG_PROGRAM([ +#ifndef __APPLE__ +#e...

...[AS_HELP_STRING([--enable-intrinsics], [Enable intrinsics optimizations (only for fixed point x86)])],, + [AS_HELP_STRING([--enable-intrinsics], [Enable intrinsics optimizations for ARM(float) X86(fixed)])],, [enable_intrinsics=no]) rtcd_support=no cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ - inline_optimization="No ASM for your platform, please send patches" + inline_optimization="No inline ASM for your platform, please send patches" case $host_cpu in arm*) dnl Currently we only have asm for fixed-point @@ -3...

...[AS_HELP_STRING([--enable-intrinsics], [Enable intrinsics optimizations (only for fixed point x86)])],, + [AS_HELP_STRING([--enable-intrinsics], [Enable intrinsics optimizations for ARM(float) X86(fixed)])],, [enable_intrinsics=no]) rtcd_support=no cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ - inline_optimization="No ASM for your platform, please send patches" + inline_optimization="No in-line ASM for your platform, please send patches" case $host_cpu in arm*) dnl Currently we only have asm for fixed-point @@ -...

...[AS_HELP_STRING([--enable-intrinsics], [Enable intrinsics optimizations (only for fixed point x86)])],, + [AS_HELP_STRING([--enable-intrinsics], [Enable intrinsics optimizations for ARM(float) X86(fixed)])],, [enable_intrinsics=no]) rtcd_support=no cpu_arm=no AS_IF([test x"${enable_asm}" = x"yes"],[ - inline_optimization="No ASM for your platform, please send patches" + inline_optimization="No inline ASM for your platform, please send patches" case $host_cpu in arm*) dnl Currently we only have asm for fixed-point @@ -3...

Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv2: - Changes recommended by Timothy for celt_neon_intr.c everything except, left the unrolled loop still unrolled - configure.ac - use AC_LINK_IFELSE instead of AC_COMPILE_IFELSE - Moved compile flags into Makefile.am - OPUS_ARM_NEON_INR --> typo --> OPUS_ARM_NEON_INTR Viswanath Puttagunta (1): armv7:

Hello, This patch introduces ARM NEON Intrinsics to optimize kf_bfly4 routine in celt part of libopus. Using NEON optimized kf_bfly4(_neon) routine helped improve performance of opus_fft_impl function by about 21.4%. The end use case was decoding a music opus ogg file. The end use case saw performance improvement of about 4.47%. This patch has 2 components i. Actual neon code to improve

From: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv1: - Rebased on top of commit aad281878: Fix celt_pitch_xcorr_c signature. which got rid of ugly code around CELT_PITCH_XCORR_IMPL passing of "arch" parameter. - Unified with --enable-intrinsics used by x86 - Modified algorithm to be more

This avoids having to use the public symbol name when jumping here, on platforms where the public symbols have an underscore prefix. --- This avoids having to add heuristics for adding prefixes to symbols in jumps to local labels as well. --- celt/arm/celt_pitch_xcorr_arm.s | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/celt/arm/celt_pitch_xcorr_arm.s

...ntrinsics], [Enable intrinsics optimizations (only for fixed point x86)])],, > + [AS_HELP_STRING([--enable-intrinsics], [Enable intrinsics optimizations for ARM(float) X86(fixed)])],, > [enable_intrinsics=no]) > > rtcd_support=no > cpu_arm=no > > AS_IF([test x"${enable_asm}" = x"yes"],[ > - inline_optimization="No ASM for your platform, please send patches" > + inline_optimization="No inline ASM for your platform, please send patches" > case $host_cpu in > arm*) > dnl Currently we only have...