openssh unix dev - May 2003 - [Bug 318] Install failure creating ssh_prng_cmds

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From dtucker at zip.com.au  2003-05-04 19:12 -------
Does anyone see any problems with the patch id #186?  It seems OK to me.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From djm at mindrot.org  2003-05-04 22:05 -------
Maybe it would just be simpler to make sure that ssh_prng_cmds.out is
world-readable after creation by "make"




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From dtucker at zip.com.au  2003-05-04 23:16 -------
I don't think that will help: "fixprogs" is run as part of
"make install" and
tries to write to the current dir as root.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From stuge-openssh-unix-dev at cdy.org  2003-05-07
18:43 -------
The only problem with patch (id=186) is that most of the commands in
ssh_prng_cmds.in will only produce meaningful output when run as root.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From dtucker at zip.com.au  2003-05-07 20:04 -------
Is that necessarily a bad thing?  ssh also uses ssh-rand-helper.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From stuge-openssh-unix-dev at cdy.org  2003-05-07
21:41 -------
Sorry, should have been clearer. fixprogs runs through all of the programs
listed in ssh_prng_cmds.in and determines whether the command works (return
code==0) and optionally how many bits of entropy the command can be expected to
really provide on the particular system. If fixprogs is run as a user and not
root, most if not all commands will be removed.

This is likely also the reason it has been put in the install phase.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From dtucker at zip.com.au  2003-05-07 22:41 -------
On my Solaris 8 host here (admittedly not locked down, so things like /var/adm 
are still readable), the output files are idential for root and non-root users.

$ make ssh_prng_cmds.out
if test ! -z "yes"; then \
        /usr/local/bin/perl ../fixprogs ssh_prng_cmds ; \
fi
$ mv ssh_prng_cmds.out ssh_prng_cmds.out.user
$ sudo make ssh_prng_cmds.out
if test ! -z "yes"; then \
        /usr/local/bin/perl ../fixprogs ssh_prng_cmds ; \
fi
$ ls -l ssh_prng*.out*
-rw-r--r--   1 root     other       1985 May  7 22:53 ssh_prng_cmds.out
-rw-r--r--   1 dtucker  dtucker     1985 May  7 22:53 ssh_prng_cmds.out.user
$ diff -u ssh_prng_cmds.out ssh_prng_cmds.out.user



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From stuge-openssh-unix-dev at cdy.org  2003-05-08
15:07 -------
Quite right.
My local machine had six lines removed as user, a Debian system I tried had 26
out of the total 52 removed, I was pretty sure this would be much worse. I'm
glad I was wrong though. :)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318





------- Additional Comments From dtucker at zip.com.au  2003-05-08 21:16 -------
OK, good.  Any other objections?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=318

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2003-05-10 16:49 -------
Fix applied.  Thanks.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.