openssh unix dev - Sep 2000 - [2.2.0p1] unable to restart sshd remotely

after I check sshd.init file, I found:
you use 'daemon' function to start sshd.

but 'daemon' will not start a daemon if the daemon process already
exist, isn't it right?

On Sat, 2 Sep 2000, MICHAEL SUN wrote:
> after I check sshd.init file, I found:
> you use 'daemon' function to start sshd.
> 
> but 'daemon' will not start a daemon if the daemon process already
> exist, isn't it right?
Yes.  This has existed at least from OpenSSH 2.0 (as long as I have been
using it).

Starting sshd fails because incoming ssh connections are registered as the
same sshd daemon processes as the one being started.  This happens in
daemon() in /etc/rc.d/init.d/functions.  The culprit is:

---
       [ -n "$pid" ] && return
---
where $pid is the number of incoming sshd connections plus one if running
sshd server at the moment.

The following is not probably not the clean solution, but I don't think
daemon keyword _can_ be used with sshd. :-/

-----
--- sshd.orig   Sat Sep  2 12:56:47 2000
+++ sshd        Sun Sep  3 11:06:03 2000
@@ -57,9 +57,9 @@
 
                echo -n "Starting sshd: "
                if [ ! -f $PID_FILE ] ; then
-                       daemon sshd
+                       /usr/sbin/sshd
                        RETVAL=$?
-                       touch /var/lock/subsys/sshd
+                       [ $RETVAL -eq 0 ] && touch /var/lock/subsys/sshd
&& echo_success
                fi
                echo
                ;;
-----


-- 
Pekka Savola                    "Tell me of difficulties surmounted, 
Pekka.Savola at netcore.fi          not those you stumble over and fall"

On Sat, 2 Sep 2000, MICHAEL SUN wrote:
> after I check sshd.init file, I found:
> you use 'daemon' function to start sshd.
> 
> but 'daemon' will not start a daemon if the daemon process already
> exist, isn't it right?
Yes. This patch should fix it, as will the updated RPMs that I am 
uploading now.

Thanks,
Damien Miller

diff -u -r1.2 -r1.3
--- contrib/redhat/sshd.init	2000/08/08 06:53:28	1.2
+++ contrib/redhat/sshd.init	2000/09/03 08:14:58	1.3
@@ -57,9 +57,14 @@
 		
 		echo -n "Starting sshd: "
 		if [ ! -f $PID_FILE ] ; then
-			daemon sshd
+			sshd
 			RETVAL=$?
-			touch /var/lock/subsys/sshd
+			if [ "$RETVAL" = "0" ] ; then
+				success "sshd startup"
+				touch /var/lock/subsys/sshd
+			else
+				failure "sshd startup"
+			fi
 		fi
 		echo
 		;;

-d

-- 
| ``The power of accurate observation is  | Damien Miller <djm at
mindrot.org>
| commonly called cynicism by those who   | @Work <djm at ibs.com.au>
| have not got it'' - George Bernard Shaw | http://www.mindrot.org