openssh bugs - Dec 2011 - [Bug 1963] New: IPQoS not honoured

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

             Bug #: 1963
           Summary: IPQoS not honoured
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 5.8p1
          Platform: amd64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: bugzilla.mindrot.org at pobox.madduck.net


While openssh-client seems to properly switch between the
lowdelay/throughput QoS classes depending on whether the session is
interactive or not, the new IPQoS option seems to have absolutely no
effect:

  % ssh -vvvo 'IPQoS ef' -4 -Snone vera 2>&1 >/dev/null |
egrep tos ||
echo no match
  debug3: packet_set_tos: set IP_TOS 0x10
  ^D
  % ssh -vvvo 'IPQoS ef' -4 -Snone vera true 2>&1 >/dev/null |
egrep
tos || echo no match
  debug3: packet_set_tos: set IP_TOS 0x08

In both cases, the TOS value should be 0x2e (class ef). Using the
hex number does not work either:

  % ssh -vvvo 'IPQoS 0x2e' -4 -Snone vera 2>&1 >/dev/null |
egrep tos
|| echo no match
  debug3: packet_set_tos: set IP_TOS 0x10
  ^D
  % ssh -vvvo 'IPQoS 0x2e' -4 -Snone vera true 2>&1 >/dev/null
| egrep
tos || echo no match
  debug3: packet_set_tos: set IP_TOS 0x08

I have also verified the actual packets emitted using tcpdump on the
next hop.

Exactly the same behaviour can be observed with IPv6 after upgrading to
1:5.9p1-7 (see http://bugs.debian.org/643312).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

martin f. krafft <bugzilla.mindrot.org at pobox.madduck.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://bugs.debian.org/6505
                   |                            |12

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1930

--- Comment #1 from Damien Miller <djm at mindrot.org> 2012-02-24 10:52:02
EST ---
Replicated, patch coming. This only affects portable OpenSSH, so we
should be able to get a fix in 6.0.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

--- Comment #2 from Damien Miller <djm at mindrot.org> 2012-02-24 10:55:19
EST ---
Created attachment 2130
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2130
bad-af.diff

Fix IPQoS in portable OpenSSH

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2130|                            |ok?(dtucker at zip.com.au)
              Flags|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2130|                            |ok+
              Flags|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

--- Comment #3 from Damien Miller <djm at mindrot.org> 2012-02-24 11:25:22
EST ---
*** Bug 1965 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

--- Comment #4 from Damien Miller <djm at mindrot.org> 2012-03-09 10:28:30
EST ---
Fix applied - this will be in openssh-6.0, due real soon. Thanks!

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1963

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.