openssh bugs - Dec 2005 - [Bug 1133] configure.ac sets wrong BROKEN_ var (snprintf/vsnprintf)

http://bugzilla.mindrot.org/show_bug.cgi?id=1133

           Summary: configure.ac sets wrong BROKEN_ var (snprintf/vsnprintf)
           Product: Portable OpenSSH
           Version: -current
          Platform: HPPA
        OS/Version: HP-UX
            Status: NEW
          Severity: major
          Priority: P2
         Component: Build system
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: dleonard at vintela.com


The autoconf.ac test for a broken vsnprintf sets BROKEN_SNPRINTF instead of
BROKEN_VSNPRINTF.

This causes breakage on HP-UX 11.00, because the (otherwise usable) snprintf
prototype in stdio.h doesn't agree with the replacement provided by OpenSSH.

Output from openssh-SNAP-20051213's configure is:

  checking whether snprintf correctly terminates long strings... yes
  checking whether vsnprintf returns correct values on overflow... no
  configure: WARNING: ****** Your vsnprintf() function is broken, complain to
your vendor

The config.h file contains no BROKEN_VSNPRINTF at all

    $ grep PRINTF config.h 
    #define BROKEN_SNPRINTF 1
    /* #undef HAVE_ASPRINTF */
    #define HAVE_SNPRINTF 1
    /* #undef HAVE_VASPRINTF */
    #define HAVE_VSNPRINTF 1

Build fails here:

    gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -std=gnu99 
-I. -I.. -I. -I./..  -D_HPUX_SOURCE -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1
-DHAVE_CONFIG_H -c bsd-snprintf.c
    bsd-snprintf.c:792: error: conflicting types for `snprintf'
    /usr/local/lib/gcc-lib/hppa2.0n-hp-hpux11.00/3.3.2/include/stdio.h:493:
error: previous declaration of `snprintf'
    *** Error exit code 1

[Credit to Ted Percival for finding this]




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1133





------- Comment #1 from dleonard at vintela.com  2005-12-16 12:09 -------
Created an attachment (id=1042)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1042&action=view)
autoconf.ac patch to use BROKEN_VSNPRINTF




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1133


ted.percival at quest.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ted.percival at quest.com




------- Comment #2 from ted.percival at quest.com  2005-12-16 12:42 -------
In response to the attachment "autoconf.ac patch to use
BROKEN_VSNPRINTF"
created 2005-12-16 12:09, it should also have the next line changed,
"snprintf"
to "vsnprintf".




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1133





------- Comment #3 from dleonard at vintela.com  2005-12-16 12:46 -------
(In reply to comment #2)

yeah actually, that patch was just totally wrong.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1133


dleonard at vintela.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1042 is|0                           |1
           obsolete|                            |




------- Comment #4 from dleonard at vintela.com  2005-12-16 12:53 -------
Created an attachment (id=1043)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1043&action=view)
configure test for SNPRINTF_CONST

This seems to work better. (Only tested on hpux)




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.