search for: login_needs_utmpx

...or themselves. Symptom: Connecting and logging in corrupted the wtmp file every time. This does not occur on AIX5L, and does not occur with OpenSSH versions 3.0 and earlier. I tracked down the cause to the change made in June 2002, reported as a bug: 20020623 - (stevesk) [configure.ac] bug #255 LOGIN_NEEDS_UTMPX for AIX. >From this point, LOGIN_NEEDS_UTMPX has been defined for all AIX builds. This is obviously needed for AIX 5L, but breaks 4.3.3's implementation as above, hence this definition needs to be conditional within the AIX section of the autoconf rules. Sorry, I'm no autoconf expert....

.... -------------- next part -------------- Index: acconfig.h --- acconfig.h 2001/04/05 17:15:08 1.110 +++ acconfig.h 2001/04/29 18:12:31 @@ -154,6 +154,12 @@ /* Define if you don't want to use wtmpx */ #undef DISABLE_WTMPX +/* Some systems need a utmpx entry for /bin/login to work */ +#undef LOGIN_NEEDS_UTMPX + +/* Some versions of /bin/login need the TERM supplied on the commandline */ +#undef LOGIN_NEEDS_TERM + /* Define if you want to specify the path to your lastlog file */ #undef CONF_LASTLOG_FILE Index: configure.in --- configure.in 2001/04/26 04:40:28 1.282 +++ configure.in 2001/04/29 18:12:3...

...ms for me. please move it up a couple hundred lines in the file. patch included for 0807 snapshot. thanks, wendy % diff -u session.c.orig session.c.mod --- session.c.orig Tue Aug 7 13:11:51 2001 +++ session.c.mod Tue Aug 7 16:21:07 2001 @@ -397,6 +397,34 @@ } } +#ifdef LOGIN_NEEDS_UTMPX +void +do_pre_login(Session *s) +{ + socklen_t fromlen; + struct sockaddr_storage from; + pid_t pid = getpid(); + + /* + * Get IP address of client. If the connection is not a socket, let + * the address be 0.0.0.0. + */ + memset(&from, 0, size...

I'm resending this patch just in case it got lost. The first hunk of the patch fixes a problem with the LOGIN_NEEDS_UTMPX support in that the date was not being set in the logininfo structure (causing wrong timestamps in the "last" log). The second hunk just omits the USE_WTMPX code in the LOGIN_NEEDS_UTMPX section if USE_UTMPX is defined. This prevents duplicate events in the last log under Solaris. Neit...

...t and noticed that a recent message from Matt Eagleson had supplied a potential patch. My version of the fix is fairly similar to Matt's, but I put the relocated record_login() call into its own function rather than putting it back into do_exec_pty(). The appended patch makes use of Matt's LOGIN_NEEDS_UTMPX autoconf changes, and has the added benefit that it doesn't call record_login() twice in the "UseLogin no" code path (which is a bug in Matt's patch). Another problem I noticed (that I haven't seen mentioned elsewhere) was that the terminal type failed to be passed through to...

...revision 1.108 diff -u -r1.108 acconfig.h --- acconfig.h 2001/03/17 01:15:38 1.108 +++ acconfig.h 2001/03/22 21:28:01 @@ -169,6 +169,9 @@ /* Define if you want to specify the path to your wtmpx file */ #undef CONF_WTMPX_FILE +/* Some systems need a utmpx entry for /bin/login to work */ +#undef LOGIN_NEEDS_UTMPX + /* Define is libutil has login() function */ #undef HAVE_LIBUTIL_LOGIN Index: configure.in =================================================================== RCS file: /cvs/openssh_cvs/configure.in,v retrieving revision 1.267 diff -u -r1.267 configure.in --- configure.in 2001/03/18 23:09:28...

...s I had to add a true prototype: *** session.c.ORIG Sun Sep 16 18:17:15 2001 --- session.c Thu Nov 15 14:45:40 2001 *************** *** 132,137 **** --- 132,140 ---- void do_child(Session *, const char *); void do_motd(void); int check_quietlogin(Session *, const char *); + #ifdef LOGIN_NEEDS_UTMPX + static void do_pre_login(Session *); + #endif static void do_authenticated1(Authctxt *); static void do_authenticated2(Authctxt *); FWIW, -- Rick Troxel rick at helix.nih.gov 301/435-2983 ///////////////////////////////////////////////////////////////// All effort and exe...

...ot; which we must do for BSM support on some of our boxes. Then, when we try to login, we get the following: No utmpx entry. You must exec "login" from the lowest level "shell". I found that message in a patch submitted in March by Matt Eagleson. However, grepping on his "LOGIN_NEEDS_UTMPX" addition makes it look like the patch has been incorporated into the codebase. So, our configure did define LOGIN_NEEDS_UTMPX, so that's not the problem. I'm wondering about a post from William Knox that includes a patch submission with the subject: "PATCH: Fixing last/utmpx fo...

...14:31:27 2002 +++ configure.ac Mon Apr 22 14:32:48 2002 @@ -236,12 +236,29 @@ AC_CHECK_FUNCS(getluid setluid) MANTYPE=man ;; +*-*-unicosmk*) + no_libsocket=1 + no_libnsl=1 + not_sco=1 + MANTYPE=cat + AC_DEFINE(USE_PIPES) + AC_DEFINE(LOGIN_NEEDS_UTMPX) + AC_DEFINE(USE_UTMP) + AC_DEFINE(USE_WTMP) + LDFLAGS="$LDFLAGS -L/usr/local/lib" + LIBS="$LIBS -lshare -lgen -lrsc -luex -lacm" + ;; *-*-unicos*) no_libsocket=1 no_libnsl=1 + not_sco=1 + MANTYPE=cat AC_DEFINE(U...

...14:31:27 2002 +++ configure.ac Mon Apr 22 14:32:48 2002 @@ -236,12 +236,29 @@ AC_CHECK_FUNCS(getluid setluid) MANTYPE=man ;; +*-*-unicosmk*) + no_libsocket=1 + no_libnsl=1 + not_sco=1 + MANTYPE=cat + AC_DEFINE(USE_PIPES) + AC_DEFINE(LOGIN_NEEDS_UTMPX) + AC_DEFINE(USE_UTMP) + AC_DEFINE(USE_WTMP) + LDFLAGS="$LDFLAGS" + LIBS="$LIBS -lshare -lgen -lrsc -luex -lacm" + ;; *-*-unicos*) no_libsocket=1 no_libnsl=1 + not_sco=1 + MANTYPE=cat AC_DEFINE(USE_PIPES) +...

http://bugzilla.mindrot.org/show_bug.cgi?id=255 ------- Additional Comments From dmanton at emea.att.com 2002-05-22 20:06 ------- Created an attachment (id=100) sshd -d -d -d ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

...====================================================== RCS file: /cvs/openssh_cvs/configure.ac,v retrieving revision 1.97 diff -u -p -r1.97 configure.ac --- configure.ac 9 Jan 2003 01:22:59 -0000 1.97 +++ configure.ac 9 Jan 2003 22:12:43 -0000 @@ -84,6 +84,7 @@ case "$host" in AC_DEFINE(LOGIN_NEEDS_UTMPX) ;; *-*-cygwin*) + check_for_libcrypt_later=1 LIBS="$LIBS /usr/lib/textmode.o" AC_DEFINE(HAVE_CYGWIN) AC_DEFINE(USE_PIPES) -- Corinna Vinschen Cygwin Developer Red Hat, Inc. mailto:vinschen at redhat.com

..._path="/usr/bin/resh" + conf_utmpx_location="/var/adm/utmpx" + cat >> confdefs.h <<\EOF + #define USE_PIPES 1 + EOF + + cat >> confdefs.h <<\EOF + #define BROKEN_SAVED_UIDS 1 + EOF + + cat >> confdefs.h <<\EOF + #define LOGIN_NEEDS_UTMPX 1 + EOF + + MANTYPE=cat + ;; *-*-sysv4.2*) CPPFLAGS="$CPPFLAGS -I/usr/local/include" LDFLAGS="$LDFLAGS -L/usr/local/lib" *** uidswap.c Thu Apr 26 15:10:15 2001 --- uidswap.c.new Mon Oct 8 11:33:42 2001 *************** *** 85,91 **** if (s...

...Jan 29 16:14:25 2002 @@ -128,7 +128,7 @@ void do_exec_pty(Session *, const char *); void do_exec_no_pty(Session *, const char *); void do_exec(Session *, const char *); -void do_login(Session *, const char *); +void do_login(Session *, const char *, const time_t, const char *); #ifdef LOGIN_NEEDS_UTMPX static void do_pre_login(Session *s); #endif @@ -548,11 +548,17 @@ { int fdout, ptyfd, ttyfd, ptymaster; pid_t pid; + char hostname[MAXHOSTNAMELEN]; + time_t last_login_time; if (s == NULL) fatal("do_exec_pty: no session");...

...== %< =================================================== --- session.c-orig Tue Oct 23 11:13:06 2001 +++ session.c-patched Tue Oct 23 11:19:54 2001 @@ -132,6 +132,9 @@ void do_child(Session *, const char *); void do_motd(void); int check_quietlogin(Session *, const char *); +#ifdef LOGIN_NEEDS_UTMPX +static void do_pre_login(Session *s); +#endif static void do_authenticated1(Authctxt *); static void do_authenticated2(Authctxt *); ================================== %< =================================================== WBR, Alexander Ignatyev AI-RIPE -------------- next part ------------...

http://bugzilla.mindrot.org/show_bug.cgi?id=1032 Summary: PrintLastLog is not working with UseLogin yes Product: Portable OpenSSH Version: 4.0p1 Platform: All OS/Version: HP-UX Status: NEW Severity: normal Priority: P2 Component: sshd AssignedTo: openssh-bugs at mindrot.org ReportedBy:

http://bass.directhit.com/openssh_snap/ Starting tonight I plan on tracking changes very closely with the OpenBSD tree. I need people to test the latest snapshot (9/14 at of right now) and report success or failure on compiling. I am starting this now because we are looking at a code freeze soon and I really want to ensure it compiles and runs on all existing platforms. So we (the portable

..., const char *realname); void do_exec_no_pty(Session *, const char *); - -void do_exec(Session *, const char *); - -void do_login(Session *, const char *); +void do_exec(Session *, const char *, const char *realname); +void do_login(Session *, const char *, const char *realname); #ifdef LOGIN_NEEDS_UTMPX static void do_pre_login(Session *s); #endif @@ -109,8 +109,8 @@ void do_motd(void); int check_quietlogin(Session *, const char *); - -static void do_authenticated1(Authctxt *); - -static void do_authenticated2(Authctxt *); +static void do_authenticated1(Authctxt *, const char *realnam...

...-r2.9.9.2 -r2.9.9.2.0.1 --- session.c 2001/09/16 22:17:15 2.9.9.2 +++ session.c 2001/09/28 18:17:11 2.9.9.2.0.1 @@ -126,6 +126,9 @@ static void session_pty_cleanup(void *); void session_proctitle(Session *); int session_setup_x11fwd(Session *); void do_exec_pty(Session *, const char *); +#ifdef LOGIN_NEEDS_UTMPX +static void do_pre_login(Session *s); +#endif void do_exec_no_pty(Session *, const char *); void do_exec(Session *, const char *); void do_login(Session *, const char *); @@ -147,6 +150,7 @@ extern int debug_flag; extern u_int utmp_len; extern int startup_pipe; extern void destroy_sensitive_...

...#ifndef HAVE_OSF_SIA if (!(options.use_login && command == NULL)) + { +# ifdef _CRAY + cray_init_job(s->pw); /* set up cray jid and tmpdir */ +# endif /* _CRAY */ do_login(s, command); + } # ifdef LOGIN_NEEDS_UTMPX else do_pre_login(s); @@ -528,6 +543,9 @@ do_child(s, command); /* NOTREACHED */ } +#ifdef _CRAY + signal(WJSIGNAL, cray_job_termination_handler); +#endif /* _CRAY */ #ifdef HAVE_CYGWIN if (is_winnt)...