openssh bugs - Jan 2004 - [Bug 788] request for zlib.h configure test

http://bugzilla.mindrot.org/show_bug.cgi?id=788

           Summary: request for zlib.h configure test
           Product: Portable OpenSSH
           Version: -current
          Platform: PPC
        OS/Version: AIX
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Build system
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: jbasney at ncsa.uiuc.edu


I see a configure test for the presence of zlib.h was removed from configure.in 
in the following revision.

----------------------------
revision 1.317
date: 2001/10/24 05:36:55;  author: tim;  state: Exp;  lines: +10 -10

[configure.in] Fix test for broken dirname. Based on patch from
Dave Dykstra <dwd at bell-labs.com>. Remove un-needed test for zlib.h.
[contrib/caldera/openssh.spec, contrib/redhat/openssh.spec,
contrib/suse/openssh.spec] Update version to match version.h
----------------------------

However, I find that some systems such as an AIX 5.2 system I'm using 
have /usr/lib/libz.a but no /usr/include/zlib.h (a broken setup, I agree).  I 
see a report at http://marc.theaimsgroup.com/?l=openssh-unix-
dev&m=106627358830467&w=2 that Compaq Tru64 UNIX has a similar setup. 
Building
OpenSSH on these systems results in a successful configure but a failed compile 
due to the missing zlib.h.  Could the zlib.h check be put back in to 
configure.ac to catch this problem earlier?  I think it might cut down on user 
confusion.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=788





------- Additional Comments From jbasney at ncsa.uiuc.edu  2004-01-15 09:27
-------
Created an attachment (id=528)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=528&action=view)
proposed patch to configure.ac




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=788





------- Additional Comments From dtucker at zip.com.au  2004-01-15 10:44 -------
Created an attachment (id=529)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=529&action=view)
Add test for zlib >= 1.1.4

Seems reasonable, as long as there was no other reason for for the original
change.

While we're at it I think we should add a test for zlib >= 1.1.4 (since
earlier
versions have security problems it has been documented as a requirement for a
while but not enforced).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=788

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
         OS/Version|AIX                         |All
           Platform|PPC                         |All





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=788

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |793
              nThis|                            |





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=788

djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Attachment #529|                            |ok
             Status|                            |



------- Additional Comments From djm at mindrot.org  2004-01-22 22:32 -------
(From update of attachment 529)
ok by me - we may be yelled at by distributors who patch zlib without cranking
the version, but if they are willing to patch zlib then they should be willing
to patch openssh too :)




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=788

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2004-01-22 23:23 -------
OK, done, thanks.  zlib 1.1.4 has been out for nearly 2 years, and if a given
vendor is backporting zlib fixes, shouldn't they also be backporting openssh
fixes anyway... 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.