I would like to add a sentence to the man page for upssched.conf. After the sentence "Note that any AT that matches both the notifytype and the upsname for the current event will be used." I propose adding the sentence "If more than one AT matches the notifytype and upsname, the AT declarations are executed in the order in which they appear in upssched.conf. This is the current behaviour so there is nothing to do technically, but I would like this behaviour to become recognized and permanent, and not unofficial and possibly ephemeral as at present. Why? The current behaviour makes it possible to restart a timer on a given event, for example by writing AT ONBATT heartbeat at localhost CANCEL-TIMER heartbeat-failure AT ONBATT heartbeat at localhost START-TIMER heartbeat-failure 660 For this to work, it is essential that the AT's are executed in the order they are written. Roger
On July 5, 2017 9:55:13 AM GMT+02:00, Roger Price <roger at rogerprice.org> wrote:>I would like to add a sentence to the man page for upssched.conf. > >After the sentence > >"Note that any AT that matches both the notifytype and the upsname for >the >current event will be used." > >I propose adding the sentence > >"If more than one AT matches the notifytype and upsname, the AT >declarations are executed in the order in which they appear in >upssched.conf. > >This is the current behaviour so there is nothing to do technically, >but I >would like this behaviour to become recognized and permanent, and not >unofficial and possibly ephemeral as at present. > >Why? The current behaviour makes it possible to restart a timer on a >given event, for example by writing > > AT ONBATT heartbeat at localhost CANCEL-TIMER heartbeat-failure > AT ONBATT heartbeat at localhost START-TIMER heartbeat-failure 660 > >For this to work, it is essential that the AT's are executed in the >order >they are written. > >Roger > >_______________________________________________ >Nut-upsdev mailing list >Nut-upsdev at lists.alioth.debian.org >http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdevYour proposal and reasoning make sense to me :) I wonder if it would be more valuable and visible if such "direct change" suggestions were added as pull requests on github, with much of the description posted there and an email to pass the URL (and maybe a pitch of the idea) and so stir up discussion in community?.. It is not too much hassle after initial repo-cloning setup, at least where people expect to contribute more than once. Jim -- Typos courtesy of K-9 Mail on my Redmi Android
On Tue, 11 Jul 2017, Jim Klimov wrote:> On July 5, 2017 9:55:13 AM GMT+02:00, Roger Price <roger at rogerprice.org> wrote: >> I propose adding the sentence >> >> "If more than one AT matches the notifytype and upsname, the AT >> declarations are executed in the order in which they appear in >> upssched.conf. > > Your proposal and reasoning make sense to me :) > > I wonder if it would be more valuable and visible if such "direct > change" suggestions were added as pull requests on github, with much of > the description posted there and an email to pass the URL (and maybe a > pitch of the idea) and so stir up discussion in community?.. It is not > too much hassle after initial repo-cloning setup, at least where people > expect to contribute more than once.My understanding was that this is the mailing list to discuss such things. I could learn about git, but I don't fancy setting up a git server. I've been retired now for nearly 20 years and I would prefer spending more time on other things. I'm not sure that git activity would generate more discussion, or acceptation. If the young guys pick up the suggestion, that's fine, but if in some future release of NUT, AT's are executed in random order, I have a solution which will keep the heartbeat working, so it's not a problem for me. Best Regards, Roger