Giuseppe Corbelli
2014-Jul-14 09:43 UTC
[Nut-upsdev] [PATCH] Support for ASEM UPS on Linux/i2c
On 07/07/2014 15:03, Charles Lepple wrote:> Giuseppe Corbelli <giuseppe.corbelli <at> copanitalia.com> writes: > >> Nevermind, please try the one attached, just created by >> >> git diff -p 80d9534 configure.ac data/driver.list.in drivers/Makefile.am >> drivers/asem.c > asem.patch >> >> Just applied it on current master (80d9534a133da170cade150700407920450a9753) >> and seems ok. > > Sorry I did not test this sooner - this went to Gmane but not to my email. > If you have time, could you please write up a quick man page for this driver?Saw you merged in master the code and the man page I should have written. Here's a small patch, adds some useful info to the man page and (most important, of course) my name to the AUTHORS file. -- Giuseppe Corbelli WASP Software Engineer, Copan Italia S.p.A Phone: +390303666318 Fax: +390302659932 E-mail: giuseppe.corbelli at copanitalia.com -------------- next part -------------- A non-text attachment was scrubbed... Name: asem_man.patch Type: text/x-patch Size: 2078 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20140714/cb8691b7/attachment.bin>
Charles Lepple
2014-Jul-14 12:39 UTC
[Nut-upsdev] [PATCH] Support for ASEM UPS on Linux/i2c
On Jul 14, 2014, at 5:43 AM, Giuseppe Corbelli <giuseppe.corbelli at copanitalia.com> wrote:> On 07/07/2014 15:03, Charles Lepple wrote: >> Giuseppe Corbelli <giuseppe.corbelli <at> copanitalia.com> writes: >> >>> Nevermind, please try the one attached, just created by >>> >>> git diff -p 80d9534 configure.ac data/driver.list.in drivers/Makefile.am >>> drivers/asem.c > asem.patch >>> >>> Just applied it on current master (80d9534a133da170cade150700407920450a9753) >>> and seems ok. >> >> Sorry I did not test this sooner - this went to Gmane but not to my email. >> If you have time, could you please write up a quick man page for this driver? > > Saw you merged in master the code and the man page I should have written. > Here's a small patch, adds some useful info to the man page and (most important, of course) my name to the AUTHORS file.Ah, right. I wrote up the man page because I couldn't find the email where I asked about the man page, but I posted that message via the Gmane web interface (and Gmane doesn't CC the author). Thanks - merged. -- Charles Lepple clepple at gmail
Charles Lepple
2014-Aug-28 12:17 UTC
[Nut-upsdev] [PATCH] Support for ASEM UPS on Linux/i2c
Giuseppe, One more question about your driver: should we put a recommendation for the "port" name in the man page? Looking at the code, it seems like it should be "/dev/i2c-0" or similar. Thanks, -- Charles Lepple clepple at gmail