Nut upsdev - Jun 2014 - [PATCH] Support for ASEM UPS on Linux/i2c

As said in previous mail, I just finished a first working version of a driver 
for the UPS found on ASEM PB1300 device
(http://www.asem.it/prodotti/industrial-automation/box-pcs/performance/pb1300/)
Linux only, accessed through i2c/SMBUS.
If you can spare some time, please review. Expecially my autotools skills are 
ehm... a bit rusty.

-- 
             Giuseppe Corbelli
WASP Software Engineer, Copan Italia S.p.A
Phone: +390303666318  Fax: +390302659932
E-mail: giuseppe.corbelli at copanitalia.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asem.patch
Type: text/x-patch
Size: 16847 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20140613/b8b1efa0/attachment.bin>

On Jun 13, 2014, at 2:53 AM, Giuseppe Corbelli <giuseppe.corbelli at
copanitalia.com> wrote:
> As said in previous mail, I just finished a first working version of a
driver for the UPS found on ASEM PB1300 device
>
(http://www.asem.it/prodotti/industrial-automation/box-pcs/performance/pb1300/)
> Linux only, accessed through i2c/SMBUS.
> If you can spare some time, please review. Expecially my autotools skills
are ehm... a bit rusty.
Hi Giuseppe,

I am not an autoconf expert, so I will admit that my first inclination was to
try and build it on a number of different boxes, and see what breaks. I don?t
see any red flags at the moment.

However, the patch file seems malformed - I got errors when passing it to ?git
apply?.

Did the patch file get edited after you generated it? What version did you
branch from?

-- 
Charles Lepple
clepple at gmail

On 18/06/2014 04:17, Charles Lepple wrote:
> On Jun 13, 2014, at 2:53 AM, Giuseppe Corbelli <giuseppe.corbelli at
copanitalia.com> wrote:
>
>> As said in previous mail, I just finished a first working version of a
driver for the UPS found on ASEM PB1300 device
>>
(http://www.asem.it/prodotti/industrial-automation/box-pcs/performance/pb1300/)
>> Linux only, accessed through i2c/SMBUS.
>> If you can spare some time, please review. Expecially my autotools
skills are ehm... a bit rusty.
>
> Hi Giuseppe,
>
> I am not an autoconf expert, so I will admit that my first inclination was
> to try and build it on a number of different boxes, and see what breaks. I
> don?t see any red flags at the moment.
>
> However, the patch file seems malformed - I got errors when passing it to
?git apply?.
>
> Did the patch file get edited after you generated it? What version did you
branch from?
Yes, I edited to avoid patching the .in generated files. Must have done 
something wrong.
Nevermind, please try the one attached, just created by

git diff -p 80d9534 configure.ac data/driver.list.in drivers/Makefile.am 
drivers/asem.c > asem.patch

Just applied it on current master (80d9534a133da170cade150700407920450a9753) 
and seems ok.

-- 
             Giuseppe Corbelli
WASP Software Engineer, Copan Italia S.p.A
Phone: +390303666318  Fax: +390302659932
E-mail: giuseppe.corbelli at copanitalia.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asem.patch
Type: text/x-patch
Size: 15928 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20140623/a9cf5a66/attachment.bin>