Nouveau - Jul 2024 - [PATCH] drm/nouveau: remove unused variable ret

Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled:

../drivers/gpu/drm/nouveau/nouveau_platform.c: In function
?nouveau_platform_probe?:
../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable
?ret? [-Werror=unused-variable]
   29 |         int ret;
      |             ^~~

Fixes: 961ae5f9807b ("drm/nouveau: handle pci/tegra drm_dev_{alloc,
register} from common code")
Cc: Ben Skeggs <bskeggs at nvidia.com>
Cc: Danilo Krummrich <dakr at kernel.org>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>

---

Cc: Karol Herbst <kherbst at redhat.com>
Cc: Lyude Paul <lyude at redhat.com>
Cc: Danilo Krummrich <dakr at redhat.com>
Cc: dri-devel at lists.freedesktop.org
Cc: nouveau at lists.freedesktop.org
---
 drivers/gpu/drm/nouveau/nouveau_platform.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_platform.c
b/drivers/gpu/drm/nouveau/nouveau_platform.c
index 3194b110eff8..829fdc6e4031 100644
--- a/drivers/gpu/drm/nouveau/nouveau_platform.c
+++ b/drivers/gpu/drm/nouveau/nouveau_platform.c
@@ -26,7 +26,6 @@ static int nouveau_platform_probe(struct platform_device
*pdev)
 	const struct nvkm_device_tegra_func *func;
 	struct nvkm_device *device = NULL;
 	struct drm_device *drm;
-	int ret;
 
 	func = of_device_get_match_data(&pdev->dev);
 
-- 
2.39.2

Hi Jani,

On Mon, Jul 29, 2024 at 03:36:24PM +0300, Jani Nikula
wrote:
> Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled:
> 
> ../drivers/gpu/drm/nouveau/nouveau_platform.c: In function
?nouveau_platform_probe?:
> ../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable
?ret? [-Werror=unused-variable]
>    29 |         int ret;
>       |             ^~~
> 
> Fixes: 961ae5f9807b ("drm/nouveau: handle pci/tegra drm_dev_{alloc,
register} from common code")
> Cc: Ben Skeggs <bskeggs at nvidia.com>
> Cc: Danilo Krummrich <dakr at kernel.org>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
Thanks for fixing this, applied to drm-misc-next.
> 
> ---
> 
> Cc: Karol Herbst <kherbst at redhat.com>
> Cc: Lyude Paul <lyude at redhat.com>
> Cc: Danilo Krummrich <dakr at redhat.com>
> Cc: dri-devel at lists.freedesktop.org
> Cc: nouveau at lists.freedesktop.org
> ---
>  drivers/gpu/drm/nouveau/nouveau_platform.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_platform.c
b/drivers/gpu/drm/nouveau/nouveau_platform.c
> index 3194b110eff8..829fdc6e4031 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_platform.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_platform.c
> @@ -26,7 +26,6 @@ static int nouveau_platform_probe(struct platform_device
*pdev)
>  	const struct nvkm_device_tegra_func *func;
>  	struct nvkm_device *device = NULL;
>  	struct drm_device *drm;
> -	int ret;
>  
>  	func = of_device_get_match_data(&pdev->dev);
>  
> -- 
> 2.39.2
>