search for: nouveau_platform_prob

...0000000247b2b64) > [ 12.050714] Call trace: > [ 12.050717] mutex_lock+0x28/0x58 > [ 12.050721] iommu_attach_device+0xac/0xf8 > [ 12.050948] nvkm_device_tegra_new+0x260/0x510 [nouveau] > [ 12.051166] nouveau_platform_device_create+0x48/0xa8 [nouveau] > [ 12.051364] nouveau_platform_probe+0x34/0x80 [nouveau] > [ 12.051368] platform_drv_probe+0x60/0xc0 > [ 12.051372] driver_probe_device+0x33c/0x4a0 > [ 12.051375] __driver_attach+0xdc/0x128 > [ 12.051377] bus_for_each_dev+0x5c/0xa8 > [ 12.051379] driver_attach+0x30/0x40 > [ 12.051381] bus_add_drive...

On Thu, Dec 21, 2017 at 12:32:39PM -0500, Anthony Eden wrote: > Hi Thierry, > > Thanks for the patch. I applied on top of linux-next-2017-12-14. > Different output this time. > > [ 11.862495] WARNING: CPU: 1 PID: 254 at > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgf100.c:391 This looks like something that could potentially be fixed by this:

On Thu, Dec 21, 2017 at 02:37:59PM -0500, Anthony Eden wrote: > I applied the changes manually. This time, Xorg is actually starting... > > [ 16.862744] WARNING: CPU: 3 PID: 381 at > drivers/gpu/drm/nouveau/nouveau_bo.c:280 nouveau_bo_new+0x450/0x4d0 > [nouveau] > [ 16.873333] Modules linked in: nouveau i2c_algo_bit ttm tegra_drm > gpio_keys drm_kms_helper drm

Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled: ../drivers/gpu/drm/nouveau/nouveau_platform.c: In function ?nouveau_platform_probe?: ../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable ?ret? [-Werror=unused-variable] 29 | int ret; | ^~~ Fixes: 961ae5f9807b ("drm/nouveau: handle pci/tegra drm_dev_{alloc, register} from common code") Cc: Ben Skeggs <bskeggs at n...

...[<c068b938>] (drm_plane_register_all) from [<c068e45c>] (drm_modeset_register_all+0xc/0x70) [ 19.138273] [<c068e45c>] (drm_modeset_register_all) from [<c06751a4>] (drm_dev_register+0x168/0x1c4) [ 19.147581] [<c06751a4>] (drm_dev_register) from [<bf1c5cd4>] (nouveau_platform_probe+0x6c/0x88 [nouveau]) [ 19.157434] [<bf1c5cd4>] (nouveau_platform_probe [nouveau]) from [<c06a3f64>] (platform_drv_probe+0x48/0x98) [ 19.167256] [<c06a3f64>] (platform_drv_probe) from [<c06a2084>] (really_probe+0x1e0/0x2cc) [ 19.175516] [<c06a2084>] (really_pr...

...938>] (drm_plane_register_all) from [<c068e45c>] (drm_modeset_register_all+0xc/0x70) > [ 19.138273] [<c068e45c>] (drm_modeset_register_all) from [<c06751a4>] (drm_dev_register+0x168/0x1c4) > [ 19.147581] [<c06751a4>] (drm_dev_register) from [<bf1c5cd4>] (nouveau_platform_probe+0x6c/0x88 [nouveau]) > [ 19.157434] [<bf1c5cd4>] (nouveau_platform_probe [nouveau]) from [<c06a3f64>] (platform_drv_probe+0x48/0x98) > [ 19.167256] [<c06a3f64>] (platform_drv_probe) from [<c06a2084>] (really_probe+0x1e0/0x2cc) > [ 19.175516] [<c06a2084&...

...[<c056200c>] (drm_plane_register_all) from [<c0564cc8>] (drm_modeset_register_all+0xc/0x70) [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from [<c054b5b8>] (drm_dev_register+0x168/0x1c4) [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] (nouveau_platform_probe+0x6c/0x88 [nouveau]) [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) from [<c05a9328>] (platform_drv_probe+0x48/0x98) [ 8.650574] [<c05a9328>] (platform_drv_probe) from [<c05a744c>] (really_probe+0x1e0/0x2cc) [ 8.658827] [<c05a744c>] (really_probe...

...by_node(args.np); > + if (!pdev) > + return -EINVAL; This is wrong, you need to handle -EPROBE_DEFER here. > + > + *mc = platform_get_drvdata(pdev); > + if (!*mc) > + return -EINVAL; > + > + *swgroup = args.args[0]; > + > + return 0; > +} > + > static int nouveau_platform_probe(struct platform_device *pdev) > { > struct nouveau_platform_gpu *gpu; > @@ -118,6 +156,10 @@ static int nouveau_platform_probe(struct platform_device *pdev) > if (IS_ERR(gpu->clk_pwr)) > return PTR_ERR(gpu->clk_pwr); > > + err = nouveau_platform_get_mc(&pde...

...nsertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_platform.c b/drivers/gpu/drm/nouveau/nouveau_platform.c index 23cd43a7fd19..bf2dc7567ea4 100644 --- a/drivers/gpu/drm/nouveau/nouveau_platform.c +++ b/drivers/gpu/drm/nouveau/nouveau_platform.c @@ -43,11 +43,10 @@ static int nouveau_platform_probe(struct platform_device *pdev) return 0; } -static int nouveau_platform_remove(struct platform_device *pdev) +static void nouveau_platform_remove(struct platform_device *pdev) { struct drm_device *dev = platform_get_drvdata(pdev); nouveau_drm_device_remove(dev); - return 0; } #if IS_E...

...h_fixed_args(dev->of_node, "mc", + 1, 0, &args); + if (ret) + return ret; + + pdev = of_find_device_by_node(args.np); + if (!pdev) + return -EINVAL; + + *mc = platform_get_drvdata(pdev); + if (!*mc) + return -EINVAL; + + *swgroup = args.args[0]; + + return 0; +} + static int nouveau_platform_probe(struct platform_device *pdev) { struct nouveau_platform_gpu *gpu; @@ -118,6 +156,10 @@ static int nouveau_platform_probe(struct platform_device *pdev) if (IS_ERR(gpu->clk_pwr)) return PTR_ERR(gpu->clk_pwr); + err = nouveau_platform_get_mc(&pdev->dev, &gpu->mc, &gp...

nvkm_mm_fini() was not called when exiting the driver, resulting in a memory leak. Fix this. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/nouveau_platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drm/nouveau/nouveau_platform.c b/drm/nouveau/nouveau_platform.c index 3691982452a9..f83aa12ee5c6 100644 --- a/drm/nouveau/nouveau_platform.c +++

...[ 2.154153] nvkm_client_ioctl+0x10/0x1c [ 2.154162] nvif_object_ctor+0xf4/0x22c [ 2.154168] nvif_device_ctor+0x28/0x70 [ 2.154174] nouveau_cli_init+0x150/0x590 [ 2.154180] nouveau_drm_device_init+0x60/0x2a0 [ 2.154187] nouveau_platform_device_create+0x90/0xd0 [ 2.154193] nouveau_platform_probe+0x3c/0x9c [ 2.154200] platform_probe+0x68/0xc0 [ 2.154207] really_probe+0xbc/0x2dc [ 2.154211] __driver_probe_device+0x78/0xe0 [ 2.154216] driver_probe_device+0xd8/0x160 [ 2.154221] __device_attach_driver+0xb8/0x134 [ 2.154226] bus_for_each_drv+0x78/0xd0 [ 2.154230] __d...

...s wrong, you need to handle -EPROBE_DEFER here. Indeed. Will fix. > >> + >> + *mc = platform_get_drvdata(pdev); >> + if (!*mc) >> + return -EINVAL; >> + >> + *swgroup = args.args[0]; >> + >> + return 0; >> +} >> + >> static int nouveau_platform_probe(struct platform_device *pdev) >> { >> struct nouveau_platform_gpu *gpu; >> @@ -118,6 +156,10 @@ static int nouveau_platform_probe(struct platform_device *pdev) >> if (IS_ERR(gpu->clk_pwr)) >> return PTR_ERR(gpu->clk_pwr); >> >> + err =...

...<c0564cc8>] > > (drm_modeset_register_all+0xc/0x70) > > [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from > > [<c054b5b8>] (drm_dev_register+0x168/0x1c4) > > [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] > > (nouveau_platform_probe+0x6c/0x88 [nouveau]) > > [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) from > > [<c05a9328>] (platform_drv_probe+0x48/0x98) > > [ 8.650574] [<c05a9328>] (platform_drv_probe) from [<c05a744c>] > > (really_probe+0x1e0/0x2cc) > &g...

...d (pid: 261, stack limit = 0x00000000247b2b64) [ 12.050714] Call trace: [ 12.050717] mutex_lock+0x28/0x58 [ 12.050721] iommu_attach_device+0xac/0xf8 [ 12.050948] nvkm_device_tegra_new+0x260/0x510 [nouveau] [ 12.051166] nouveau_platform_device_create+0x48/0xa8 [nouveau] [ 12.051364] nouveau_platform_probe+0x34/0x80 [nouveau] [ 12.051368] platform_drv_probe+0x60/0xc0 [ 12.051372] driver_probe_device+0x33c/0x4a0 [ 12.051375] __driver_attach+0xdc/0x128 [ 12.051377] bus_for_each_dev+0x5c/0xa8 [ 12.051379] driver_attach+0x30/0x40 [ 12.051381] bus_add_driver+0x218/0x2b8 [ 12.051384]...

...lane_register_all) from [<c0564cc8>] > (drm_modeset_register_all+0xc/0x70) > [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from > [<c054b5b8>] (drm_dev_register+0x168/0x1c4) > [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] > (nouveau_platform_probe+0x6c/0x88 [nouveau]) > [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) from > [<c05a9328>] (platform_drv_probe+0x48/0x98) > [ 8.650574] [<c05a9328>] (platform_drv_probe) from [<c05a744c>] > (really_probe+0x1e0/0x2cc) > [ 8.658827] [<c0...

...form_driver); +#endif } module_init(nouveau_drm_init); diff --git a/drm/nouveau_platform.c b/drm/nouveau_platform.c index b307bbedd4c4..34d78b288f97 100644 --- a/drm/nouveau_platform.c +++ b/drm/nouveau_platform.c @@ -177,9 +177,3 @@ struct platform_driver nouveau_platform_driver = { .probe = nouveau_platform_probe, .remove = nouveau_platform_remove, }; - -module_platform_driver(nouveau_platform_driver); - -MODULE_AUTHOR(DRIVER_AUTHOR); -MODULE_DESCRIPTION(DRIVER_DESC); -MODULE_LICENSE("GPL and additional rights"); diff --git a/drm/nouveau_platform.h b/drm/nouveau_platform.h index 58c28b5653d5.....

..._register_all+0xc/0x70) > > > > [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from > > > > [<c054b5b8>] (drm_dev_register+0x168/0x1c4) > > > > [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] > > > > (nouveau_platform_probe+0x6c/0x88 [nouveau]) > > > > [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) > > > > from > > > > [<c05a9328>] (platform_drv_probe+0x48/0x98) > > > > [ 8.650574] [<c05a9328>] (platform_drv_probe) from > > &gt...

...t; > (drm_modeset_register_all+0xc/0x70) > > > [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from > > > [<c054b5b8>] (drm_dev_register+0x168/0x1c4) > > > [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] > > > (nouveau_platform_probe+0x6c/0x88 [nouveau]) > > > [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) > > > from > > > [<c05a9328>] (platform_drv_probe+0x48/0x98) > > > [ 8.650574] [<c05a9328>] (platform_drv_probe) from > > > [<c05a744c>]...

Hi, This series includes some pieces of fixes to complete the GK20A power on/off sequences and add the suspend/resume support. The patches 1/11 - 4/11 are based on the linux-next-20141219. The patches 5/11 - 11/11 are based on the branch "linux-3.19" of Ben Skeggs's tree (http://cgit.freedesktop.org/~darktama/nouveau). Thanks, Vince Vince Hsu (4): (linux-next-20141219) ARM: