Nouveau - Jan 2023 - [REGRESSION] GM20B probe fails after commit 2541626cfb79

On Fri, 20 Jan 2023 at 21:37, Diogo Ivo <diogo.ivo at tecnico.ulisboa.pt>
wrote:
>
> On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote:
> > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo <diogo.ivo at
tecnico.ulisboa.pt> wrote:
> > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote:
> > > > As a quick check can you try changing
> > > >
> > > >
drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target
> > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH ?
>
> > In addition to Dave's change, can you try changing the
> > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to:
> >
> > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM, addr_args,
> > sizeof(args), 0, false);
>
> Hello!
>
> Chiming in just to say that with this change I see the same as Nicolas
> except that the init message size is 255 instead of 0:
>
> [    2.196934] nouveau 57000000.gpu: pmu: unexpected init message size 255
vs 42
I've attached an entirely untested patch (to go on top of the other
hacks/fixes so far), that will hopefully get us a little further.

Would be great if you guys could test it out for me.

Thanks,
Ben.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gm20b.diff
Type: text/x-patch
Size: 1030 bytes
Desc: not available
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20230127/1d2002f0/attachment.bin>

Le ven. 27 janv. 2023 ? 07:01, Ben Skeggs <skeggsb at gmail.com> a ?crit
:
>
> On Fri, 20 Jan 2023 at 21:37, Diogo Ivo <diogo.ivo at
tecnico.ulisboa.pt> wrote:
> >
> > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote:
> > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo <diogo.ivo at
tecnico.ulisboa.pt> wrote:
> > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie
wrote:
> > > > > As a quick check can you try changing
> > > > >
> > > > >
drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target
> > > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH ?
> >
> > > In addition to Dave's change, can you try changing the
> > > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to:
> > >
> > > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM,
addr_args,
> > > sizeof(args), 0, false);
> >
> > Hello!
> >
> > Chiming in just to say that with this change I see the same as Nicolas
> > except that the init message size is 255 instead of 0:
> >
> > [    2.196934] nouveau 57000000.gpu: pmu: unexpected init message size
255 vs 42
> I've attached an entirely untested patch (to go on top of the other
> hacks/fixes so far), that will hopefully get us a little further.
>
> Would be great if you guys could test it out for me.
Hello,

Thanks for the patch. It works for me on: jetson-tx1:
---
[ 1022.814699] nouveau 57000000.gpu: NVIDIA GM20B (12b000a1)
[ 1022.814750] nouveau 57000000.gpu: imem: using IOMMU
[ 1022.893976] nouveau 57000000.gpu: DRM: VRAM: 0 MiB
[ 1022.893988] nouveau 57000000.gpu: DRM: GART: 1048576 MiB
[ 1022.895356] nouveau 57000000.gpu: DRM: MM: using COPY for buffer copies
[ 1022.897046] [drm] Initialized nouveau 1.3.1 20120801 for
57000000.gpu on minor 1
---
I've tried to run glmark2-wayland under weston with DRI_PRIME=1, it
seems to work at the beginning, but then I have the following error:

[ 1510.861730] nouveau 57000000.gpu: gr: DATA_ERROR 00000003
[INVALID_OPERATION] ch 3 [04002a2000 glmark2-wayland[2753]] subc 0
class b197 mthd 19d0 data 0000003d
[ 1510.952000] nouveau 57000000.gpu: gr: DATA_ERROR 00000003
[INVALID_OPERATION] ch 3 [04002a2000 glmark2-wayland[2753]] subc 0
class b197 mthd 19d0 data 0000003d
[ 1510.952060] nouveau 57000000.gpu: gr: DATA_ERROR 0000009c [] ch 3
[04002a2000 glmark2-wayland[2753]] subc 0 class b197 mthd 0d78 data
00000006
I think it's a separate error as I think I can reproduce on kernel
6.1x (I will open a separate thread).

So you can add my
Tested-By: Nicolas Chauvet <kwizart at gmail.com>

Thanks

On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs
wrote:
> On Fri, 20 Jan 2023 at 21:37, Diogo Ivo <diogo.ivo at
tecnico.ulisboa.pt> wrote:
> >
> > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote:
> > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo <diogo.ivo at
tecnico.ulisboa.pt> wrote:
> > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie
wrote:
> > > > > As a quick check can you try changing
> > > > >
> > > > >
drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target
> > > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH ?
> >
> > > In addition to Dave's change, can you try changing the
> > > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to:
> > >
> > > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM,
addr_args,
> > > sizeof(args), 0, false);
> >
> > Chiming in just to say that with this change I see the same as Nicolas
> > except that the init message size is 255 instead of 0:
> >
> > [    2.196934] nouveau 57000000.gpu: pmu: unexpected init message size
255 vs 42
> I've attached an entirely untested patch (to go on top of the other
> hacks/fixes so far), that will hopefully get us a little further.
Hello,

Thank you for the patch! I can confirm that it fixes the problem
on the Pixel C, and everything works as before the regression.
With this, for the combination of patches

Tested-by: Diogo Ivo <diogo.ivo at tecnico.ulisboa.pt> 

which I can resend after testing the final patch version.

Thanks,
Diogo

On Fri, 27 Jan 2023 at 20:42, Diogo Ivo <diogo.ivo at tecnico.ulisboa.pt>
wrote:
>
> On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote:
> > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo <diogo.ivo at
tecnico.ulisboa.pt> wrote:
> > >
> > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote:
> > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo <diogo.ivo at
tecnico.ulisboa.pt> wrote:
> > > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie
wrote:
> > > > > > As a quick check can you try changing
> > > > > >
> > > > > >
drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target
> > > > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH
?
> > >
> > > > In addition to Dave's change, can you try changing the
> > > > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to:
> > > >
> > > > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM,
addr_args,
> > > > sizeof(args), 0, false);
> > >
> > > Chiming in just to say that with this change I see the same as
Nicolas
> > > except that the init message size is 255 instead of 0:
> > >
> > > [    2.196934] nouveau 57000000.gpu: pmu: unexpected init message
size 255 vs 42
> > I've attached an entirely untested patch (to go on top of the
other
> > hacks/fixes so far), that will hopefully get us a little further.
>
> Hello,
>
> Thank you for the patch! I can confirm that it fixes the problem
> on the Pixel C, and everything works as before the regression.
> With this, for the combination of patches
>
> Tested-by: Diogo Ivo <diogo.ivo at tecnico.ulisboa.pt>
>
> which I can resend after testing the final patch version.
Thank you (both!) for testing!

I've attached a "final" version of a patch that I'll send
(assuming it
still works ;)) after re-testing.  There's only a minor change to
avoid breaking the non-Tegra path, so I expect it should be fine.

Ben.
>
> Thanks,
> Diogo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-nouveau-acr-gm20b-regression-fixes.patch
Type: text/x-patch
Size: 2775 bytes
Desc: not available
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20230130/69736cfa/attachment-0001.bin>