ChunyouTang
2021-Mar-17 09:35 UTC
[Nouveau] [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable
From: tangchunyou <tangchunyou at yulong.com>
disable,delete disable and return 0
Signed-off-by: tangchunyou <tangchunyou at yulong.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
index fb90d47..a9cdf24 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
@@ -32,7 +32,6 @@
struct nvkm_device *device = init->subdev.device;
u32 r001540 = nvkm_rd32(device, 0x001540);
u32 r00154c = nvkm_rd32(device, 0x00154c);
- u64 disable = 0;
if (!(r001540 & 0x40000000)) {
nvkm_subdev_disable(device, NVKM_ENGINE_MSPDEC, 0);
@@ -48,7 +47,7 @@
if (!(r00154c & 0x00000200))
nvkm_subdev_disable(device, NVKM_ENGINE_CE, 0);
- return disable;
+ return 0;
}
static const struct nvkm_devinit_func
--
1.9.1
Ben Skeggs
2021-Mar-24 23:28 UTC
[Nouveau] [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable
On Wed, 17 Mar 2021 at 19:51, ChunyouTang <tangchunyou at 163.com> wrote:> > From: tangchunyou <tangchunyou at yulong.com> > > disable,delete disable and return 0 > > Signed-off-by: tangchunyou <tangchunyou at yulong.com>Thanks!> --- > drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c > index fb90d47..a9cdf24 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c > @@ -32,7 +32,6 @@ > struct nvkm_device *device = init->subdev.device; > u32 r001540 = nvkm_rd32(device, 0x001540); > u32 r00154c = nvkm_rd32(device, 0x00154c); > - u64 disable = 0; > > if (!(r001540 & 0x40000000)) { > nvkm_subdev_disable(device, NVKM_ENGINE_MSPDEC, 0); > @@ -48,7 +47,7 @@ > if (!(r00154c & 0x00000200)) > nvkm_subdev_disable(device, NVKM_ENGINE_CE, 0); > > - return disable; > + return 0; > } > > static const struct nvkm_devinit_func > -- > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel