Baole Ni
2016-Aug-02 10:49 UTC
[Nouveau] [PATCH 0206/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com> Signed-off-by: Baole Ni <baolex.ni at intel.com> --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 300ea03..33d60e5 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -53,7 +53,7 @@ MODULE_PARM_DESC(nofbaccel, "Disable fbcon acceleration"); int nouveau_nofbaccel = 0; -module_param_named(nofbaccel, nouveau_nofbaccel, int, 0400); +module_param_named(nofbaccel, nouveau_nofbaccel, int, S_IRUSR); static void nouveau_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect) -- 2.9.2
Possibly Parallel Threads
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0202/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0203/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0204/1285] Replace numeric parameter like 0444 with macro