Alexandre Courbot
2015-May-15 07:11 UTC
[Nouveau] [PATCH] nouveau: add coherent BO attribute
Re-pinging Marteen on an email address that still exists :P On Wed, Apr 22, 2015 at 6:08 PM, Alexandre Courbot <gnurou at gmail.com> wrote:> On Sun, Mar 15, 2015 at 5:41 PM, Alexandre Courbot <acourbot at nvidia.com> wrote: >> On 03/14/2015 04:33 AM, Maarten Lankhorst wrote: >>> >>> Hey, >>> >>> Op 13-03-15 om 07:27 schreef Alexandre Courbot: >>>> >>>> Add a flag allowing Nouveau to specify that an object should be coherent >>>> at allocation time. This is required for some class of objects like >>>> fences which are randomly-accessed by both the CPU and GPU. This flag >>>> instructs the kernel driver to make sure the object remains coherent >>>> even on architectures for which coherency is not guaranteed by the bus. >>>> >>>> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> >>> >>> I don't see a problem with this patch, but similar patches to intel to >>> libdrm have been shot down when the changes weren't in an official kernel >>> yet, so I think this should wait until the change is at least in drm-next. >>> ;-) >> >> >> Sounds good. I will ping you again once the kernel change reaches -next. > > Hi Marteen, > > The kernel change required for this patch is now in -next. Do you > think we can merge it now?
Maarten Lankhorst
2015-May-15 11:39 UTC
[Nouveau] [PATCH] nouveau: add coherent BO attribute
Op 15-05-15 om 09:11 schreef Alexandre Courbot:> Re-pinging Marteen on an email address that still exists :P > > On Wed, Apr 22, 2015 at 6:08 PM, Alexandre Courbot <gnurou at gmail.com> wrote: >> On Sun, Mar 15, 2015 at 5:41 PM, Alexandre Courbot <acourbot at nvidia.com> wrote: >>> On 03/14/2015 04:33 AM, Maarten Lankhorst wrote: >>>> Hey, >>>> >>>> Op 13-03-15 om 07:27 schreef Alexandre Courbot: >>>>> Add a flag allowing Nouveau to specify that an object should be coherent >>>>> at allocation time. This is required for some class of objects like >>>>> fences which are randomly-accessed by both the CPU and GPU. This flag >>>>> instructs the kernel driver to make sure the object remains coherent >>>>> even on architectures for which coherency is not guaranteed by the bus. >>>>> >>>>> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> >>>> I don't see a problem with this patch, but similar patches to intel to >>>> libdrm have been shot down when the changes weren't in an official kernel >>>> yet, so I think this should wait until the change is at least in drm-next. >>>> ;-) >>> >>> Sounds good. I will ping you again once the kernel change reaches -next. >> Hi Marteen, >> >> The kernel change required for this patch is now in -next. Do you >> think we can merge it now?I think it would be ok to merge now. ~Maarten
Alexandre Courbot
2015-May-20 05:11 UTC
[Nouveau] [PATCH] nouveau: add coherent BO attribute
On Fri, May 15, 2015 at 8:39 PM, Maarten Lankhorst <maarten at mblankhorst.nl> wrote:> Op 15-05-15 om 09:11 schreef Alexandre Courbot: >> Re-pinging Marteen on an email address that still exists :P >> >> On Wed, Apr 22, 2015 at 6:08 PM, Alexandre Courbot <gnurou at gmail.com> wrote: >>> On Sun, Mar 15, 2015 at 5:41 PM, Alexandre Courbot <acourbot at nvidia.com> wrote: >>>> On 03/14/2015 04:33 AM, Maarten Lankhorst wrote: >>>>> Hey, >>>>> >>>>> Op 13-03-15 om 07:27 schreef Alexandre Courbot: >>>>>> Add a flag allowing Nouveau to specify that an object should be coherent >>>>>> at allocation time. This is required for some class of objects like >>>>>> fences which are randomly-accessed by both the CPU and GPU. This flag >>>>>> instructs the kernel driver to make sure the object remains coherent >>>>>> even on architectures for which coherency is not guaranteed by the bus. >>>>>> >>>>>> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> >>>>> I don't see a problem with this patch, but similar patches to intel to >>>>> libdrm have been shot down when the changes weren't in an official kernel >>>>> yet, so I think this should wait until the change is at least in drm-next. >>>>> ;-) >>>> >>>> Sounds good. I will ping you again once the kernel change reaches -next. >>> Hi Marteen, >>> >>> The kernel change required for this patch is now in -next. Do you >>> think we can merge it now? > I think it would be ok to merge now.Great - who could do this? :P